-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI initialization flow and reset when devices < 2 from native side #1109
Conversation
f34d303
to
5cf5aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and confirmed it fixes all referenced issues but not brave/brave-browser#2523 which is fixed already, and brave/brave-browser#2527 which was not fixed while trying these changes. otherwise lgtm great work on this one
Fix UI initialization flow and reset when devices < 2 from native side
Fix UI initialization flow and reset when devices < 2 from native side
Fix UI initialization flow and reset when devices < 2 from native side
Changing the flag as this has already been merged into
After talking with @rebron, we'll keep this in |
Also moved the following into |
fix brave/brave-browser#2533
fix brave/brave-browser#2537
fix brave/brave-browser#2540
fix brave/brave-browser#2552
fix brave/brave-browser#2575
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Except test case in above issues, here is the critical case:
Reviewer Checklist: