Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads needs text #2536

Closed
NejcZdovc opened this issue Dec 13, 2018 · 3 comments
Closed

Ads needs text #2536

NejcZdovc opened this issue Dec 13, 2018 · 3 comments
Labels
closed/invalid closed/not-actionable

Comments

@NejcZdovc
Copy link
Contributor

What should we show instead of coming soon?

image

cc @davidtemkin @jenn-rhim
@NejcZdovc NejcZdovc added feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 13, 2018
@mrose17
Copy link
Member

mrose17 commented Dec 13, 2018

what we should do is to have the text say that adds are in beta and available only to special beta testers. And leave it at that!

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Dec 13, 2018
@mandar-brave
Copy link

@NejcZdovc https://docs.google.com/document/d/1sjW_XPjUctoLRQN0VMqNbhukKJFg92YHNeYWd81ySYs/edit#

See details

@NejcZdovc
Copy link
Contributor Author

fixed with brave/brave-core#1283

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 21, 2019
@kjozwiak kjozwiak removed feature/ads feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 6, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@kjozwiak kjozwiak mentioned this issue May 14, 2020
Closed
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid closed/not-actionable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mrose17 @bbondy @kjozwiak @rebron @NejcZdovc @mandar-brave