Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] May ads payout recovery #9733

Closed
kjozwiak opened this issue May 12, 2020 · 4 comments
Closed

[Android] May ads payout recovery #9733

kjozwiak opened this issue May 12, 2020 · 4 comments
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA/No release-notes/include

Comments

@kjozwiak
Copy link
Member

We should preform one time check on user ad promotion and if it's in the bad state because of empty public key recover from it.

Test plan

See brave/brave-core#5495 (comment) & brave/brave-core#5495 (comment)

@kjozwiak
Copy link
Member Author

@NejcZdovc I think this is going to be difficult to QA on android. Other than checking if rewards is still working, is there anything that QA can do here? We don't have access the database so won't be able to edit anything.

@kjozwiak
Copy link
Member Author

kjozwiak commented May 13, 2020

Waiting on a build that includes #9766 before QA can go through the cases outlined in See brave/brave-core#5495 (comment) & brave/brave-core#5495 (comment).

@kjozwiak
Copy link
Member Author

After speaking with @NejcZdovc @SergeyZhukovsky @bbondy, we're going to release without checking the above. We did make sure that the above fix is working on the following platforms:

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels May 14, 2020
@kjozwiak
Copy link
Member Author

@srirambv once #9766 is implemented, we should double check this just to make sure it's working just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA/No release-notes/include
Projects
None yet
Development

No branches or pull requests

1 participant