Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update Start using Brave Rewards modal design #26041

Closed
Miyayes opened this issue Oct 14, 2022 · 1 comment · Fixed by brave/brave-core#15430
Closed

[Android] Update Start using Brave Rewards modal design #26041

Miyayes opened this issue Oct 14, 2022 · 1 comment · Fixed by brave/brave-core#15430
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 14, 2022 •
edited
Loading

Description

Existing:

image

Design:

https://www.figma.com/file/ag8i1OV5vpvn4SiOhW2c0f/Github-fixes?node-id=1750%3A49149

image
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Oct 14, 2022
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. polish Nice to have — usually related to front-end/visual tasks labels Oct 14, 2022
@deeppandya deeppandya mentioned this issue Oct 18, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 18, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 17, 2022 •
edited
Loading

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.46.114

1.45.12 1.46.114
Screenshot_20221117_123500 Screenshot_20221117_124055

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.46.114

1.45.12 1.46.114
Screenshot_20221117-131746_Brave Screenshot_20221117-133052_Brave - Beta

@kjozwiak kjozwiak mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Declare geo rewards android brave/brave-core
5 participants
@deeppandya @Miyayes @sujitacharya2005 @GeetaSarvadnya @brave-builds