Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent the user from firing device removal multiple times #2629

Closed
darkdh opened this issue Dec 18, 2018 · 3 comments · Fixed by brave/brave-core#1193
Closed

prevent the user from firing device removal multiple times #2629

darkdh opened this issue Dec 18, 2018 · 3 comments · Fixed by brave/brave-core#1193
Assignees
@cezaraugusto
Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Dec 18, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1193

Description

#2527 (comment)
#2527 (comment)

we need to prevent user from clicking remove multiple times(sending duplicated delete record) while delete record is sending under the hood. we also need to dismiss the remove modal when user click "Remove"

Test Plan:

  1. have 3 devices in a sync chain
  2. once devices are loaded, remove one device by clicking the X button
  3. confirm removal
  4. all buttons should be disabled
  5. a loading spinner should show while the operation is running
  6. modal should self-close once operation is completed
@darkdh darkdh added this to the 0.59.x - Beta milestone Dec 18, 2018
@darkdh darkdh mentioned this issue Dec 18, 2018
Closed
@cezaraugusto
Copy link
Contributor

cc @rossmoody

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 20, 2018
@bbondy bbondy modified the milestones: 0.59.x - Beta, 1.x Backlog Dec 20, 2018
@rossmoody
Copy link
Contributor

The most up to date design spec for Sync can be found right here.

@cezaraugusto cezaraugusto mentioned this issue Jan 1, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
add a loading state for removing and reseting sync
021ad13 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
@cezaraugusto cezaraugusto changed the title Remove device modal refinement prevent user from firing device removal multiple times Jan 2, 2019
@cezaraugusto cezaraugusto changed the title prevent user from firing device removal multiple times prevent the user from firing device removal multiple times Jan 2, 2019
@cezaraugusto cezaraugusto added QA/Yes and removed QA/No labels Jan 2, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
add a loading state for adding, removing and reseting sync
bd48127 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto
add a loading state for adding, removing and reseting sync
24867f7 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

screenshot from 2019-01-08 13-00-28

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix multiple sync issues brave/brave-core
8 participants
@bbondy @cezaraugusto @bsclifton @darkdh @srirambv @LaurenWags @rossmoody @GeetaSarvadnya