Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash from Google Play Console on home button preferences #26440

Closed
SergeyZhukovsky opened this issue Nov 1, 2022 · 1 comment · Fixed by brave/brave-core#15741 or brave/brave-core#15773
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Nov 1, 2022

Description

Crash when navigating to settings > Notifications > In-app notifications.
Note: It happens on stable channel only.

Exception java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources$Theme android.content.Context.getTheme()' on a null object reference
  at com.google.android.play.core.internal.aq.i (aq.java:6)
  at com.google.android.play.core.internal.an.a (an.java:6)
  at androidx.preference.Preference.<init> (Preference.java:315)
  at com.google.android.gms.cloudmessaging.zzh.<init> (com.google.android.gms:play-services-cloud-messaging@@16.0.0:2)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase.i3 (BraveMainPreferencesBase.java:325)
  at org.chromium.chrome.browser.toolbar.ButtonDataImpl.run (ButtonDataImpl.java:3)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7842)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)
Exception java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources$Theme android.content.Context.getTheme()' on a null object reference
  at androidx.core.content.res.TypedArrayUtils.getAttr (TypedArrayUtils.java:355)
  at androidx.preference.Preference.<init> (Preference.java:315)
  at androidx.preference.Preference.<init> (Preference.java:326)
  at org.chromium.chrome.browser.settings.VpnCalloutPreference.<init> (VpnCalloutPreference.java:32)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase.rearrangePreferenceOrders (BraveMainPreferencesBase.java:182)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase.updateBravePreferences (BraveMainPreferencesBase.java:147)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase.lambda$onResume$0 (BraveMainPreferencesBase.java:116)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase.$r8$lambda$NgSxF-DGhI0embP02coyf6_iVJw (BraveMainPreferencesBase.java:325)
  at org.chromium.chrome.browser.settings.BraveMainPreferencesBase$$InternalSyntheticLambda$1$5311148cd34ee2cd13211cdab6bdbc40b4bc2e364f5981e603a0df0d8ddfba83$0.run (BraveMainPreferencesBase.java:3)
  at android.os.Handler.handleCallback (Handler.java:873)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:214)
  at android.app.ActivityThread.main (ActivityThread.java:7156)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:494)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:975)

Steps to reproduce

  1. Clean install
  2. Navigate to settings > notifications > in-app notifications
  3. Observe

Actual result

in_app_settings_crash.mp4

Expected result

no crash

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy devices
  • Android version: 12, 11

Brave version

1.45.116

@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality labels Nov 1, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 1, 2022
@SergeyZhukovsky SergeyZhukovsky added this to the 1.47.x - Nightly milestone Nov 1, 2022
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Nov 2, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

Verification PASSED on Samsung Galaxy S10+ running Android 12 using the following build(s):

Brave | 1.45.120 Chromium: 107.0.5304.91 (Official Build) (32-bit)
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Android 12; Build/SP1A.210812.016

Using the STR/Cases outlined via #26440 (comment), verified the Brave doesn't crash when going into Settings -> Notifications -> in-app notifications as per the following:

Screen_Recording_20221104_022629_Brave.mp4

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.45.120 Chromium: 107.0.5304.91 (Official Build) (32-bit)
--- | ---
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Android 12; Build/SP2A.220305.013

Using the STR/Cases outlined via #26440 (comment), verified the Brave doesn't crash when going into Settings -> Notifications -> in-app notifications as per the following:

Screen_Recording_20221104_024823_Brave.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
3 participants