Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] 0.58.x sync issues that still need to be verified (macOS only) #2671

Closed
LaurenWags opened this issue Dec 20, 2018 · 2 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 20, 2018

Because it was decided that sync won't be going out enabled by default in 0.58.x, QA concentrated on verifying other issues. Because the following PR/fixes already landed in 0.58.x, we need to verify that the following have also been QA'd/verified for sync on macOS:

This issue is specific to macOS, however CCing @brave/legacy_qa please let me know if there's anything that I might have missed.

@LaurenWags
Copy link
Member Author

Verified all issues passed (or have follow up issues logged) except for #2552 and #2533 which were reopened and moved to a different milestone as noted above.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

Thanks @LaurenWags 👍 Looks like #2552 and #2533 were fixed by brave/brave-core#1191 which was originally in 0.60.x but was merged into 0.59.x via brave/brave-core#1191 (comment). Moved all the issues that were mentioned in brave/brave-core#1191 into 0.59.x 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants