Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to sync the device with itself #2539

Closed
btlechowski opened this issue Dec 13, 2018 · 4 comments
Closed

Possible to sync the device with itself #2539

btlechowski opened this issue Dec 13, 2018 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Dec 13, 2018

Steps to Reproduce

1 Clean install.
2. Go to chrome://sync/
3. Click Start a new sync chain -> Computer
4. Copy Sync code
5. Close all the modals and click Enter a sync chain code
6. Paste the code from 4.

Actual result:

The device is synced with itself

image

sync2

Expected result:

the device is not synced with itself

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

@brave/legacy_qa

@srirambv srirambv added this to the 1.x Backlog milestone Dec 14, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@cezaraugusto
Copy link
Contributor

after brave/brave-core#1094 we are resetting Sync when the devices modal is closed meaning that once you type your sync words the code word copied is not from the current device but from an abandoned chain, so I'm going to close this. Please re-open if you disagree

@cezaraugusto
Copy link
Contributor

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified the STR mentioned in the issue.

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR mentioned in the issue.

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified STR from description

@cezaraugusto
Copy link
Contributor

I've bring up this issue in https://bravesoftware.slack.com/archives/C2HJYB45N/p1546637100018400 and we're considering that it's ok to have it as-is so I'm marking this as invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment