Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of space in the tipping banner #26739

Closed
GeetaSarvadnya opened this issue Nov 14, 2022 · 6 comments · Fixed by brave/brave-core#16081
Closed

Lots of space in the tipping banner #26739

GeetaSarvadnya opened this issue Nov 14, 2022 · 6 comments · Fixed by brave/brave-core#16081

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2022

Description

Lots of space in the tipping banner

Steps to reproduce

  1. Clean profile 1.46.109
  2. Enable rewards
  3. Open a site and tap on Send Tip
  4. Tipping banner is shown with lot of empty space

Actual result

Lots of space in the tipping the banner
image

Expected result

should not be any empty space

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Tab A7
  • Android version: version 12

Brave version

1.46.109

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @deeppandya @Miyayes

@deeppandya
Copy link

@sujitacharya2005 can you look into this issue as it's related to tipping banner ?

@sujitacharya2005
Copy link

@Miyayes
This seems issue in Tablet.
Where lot of empty space is coming.

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 16, 2022

Seems like tablet-specific issue, so added a label. That said, ideally @sujitacharya2005, you could reduce the overall size of the tipping banner (the blue part, bring it down so that it's roughly 50% height of screen), and then blur/darken the webpage behind the tipping banner.

@stephendonner stephendonner changed the title Lots of space in the tipping the banner Lots of space in the tipping banner Nov 16, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 18, 2022
@kjozwiak
Copy link
Member

Closing as the above has been fixed via brave/brave-core#16081 (comment).

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2022

The above will require 1.46.141 or higher for 1.46.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (32-bit)
--- | ---
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Android 13; Build/TP1A.220624.014
Example Example
Screenshot_20221212_142725_Brave Screenshot_20221212_142735_Brave

Created #27251 as a follow up re: blurring/darkening inactive areas while the tipping banner is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants