Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show close button in tipping banner (uplift to 1.47.x) #16115

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Show close button in tipping banner (uplift to 1.47.x) #16115

merged 1 commit into from
Dec 9, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 28, 2022 •
edited by kjozwiak
Loading

Uplift of #16081
Resolves brave/brave-browser#26744
Resolves brave/brave-browser#26739
Resolves brave/brave-browser#26740

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 28, 2022 18:52
@brave-builds brave-builds self-assigned this Nov 28, 2022
@brave-builds brave-builds added this to the 1.47.x - Beta milestone Nov 28, 2022
kjozwiak
kjozwiak approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16081 (comment).

@kjozwiak kjozwiak merged commit 14f2991 into 1.47.x Dec 9, 2022
@kjozwiak kjozwiak deleted the pr16081_26744_Close_x_button_tipping_banner_1.47.x branch December 9, 2022 05:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

⚠️ PR head is an unsigned commit
commit: 7c22575
reason: unsigned
Please follow the handbook to configure commit signing
cc: @brave-browser-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases