Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text in the first screen (disabled content) feels extremely cramped and uneven #2675

Closed
cezaraugusto opened this issue Dec 20, 2018 · 3 comments · Fixed by brave/brave-core#1193
Closed

Text in the first screen (disabled content) feels extremely cramped and uneven #2675

cezaraugusto opened this issue Dec 20, 2018 · 3 comments · Fixed by brave/brave-core#1193
Assignees
@cezaraugusto
Labels
design A design change, especially one which needs input from the design team feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Dec 20, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1193

Description

carried over from #2500

Since this is a design tweak I'm labeling this as QA/no
@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team feature/sync QA/No release-notes/exclude labels Dec 20, 2018
@cezaraugusto cezaraugusto added this to the 0.60.x - Dev milestone Dec 20, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 20, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 20, 2018
Closed
@rossmoody
Copy link
Contributor

Updated polish:
image

@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 1.x Backlog Dec 21, 2018
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 1, 2019
@cezaraugusto
update spec of sync disabled view
3f9ba6d 
fix brave/brave-browser#2675
@cezaraugusto cezaraugusto mentioned this issue Jan 1, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
update spec of sync disabled view
82d2f0d 
fix brave/brave-browser#2675
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto
update spec of sync disabled view
1947755 
fix brave/brave-browser#2675
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@btlechowski
Copy link

Changed the label to QA/Yes after talking to @kjozwiak.

@btlechowski btlechowski added QA/Yes and removed QA/No labels Jan 8, 2019
@btlechowski
Copy link

btlechowski commented Jan 8, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-08 at 3 30 22 pm

Verification PASSED on Mint 18.3 x64 using the following build:

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-09 at 1 59 45 am

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix multiple sync issues brave/brave-core
7 participants
@kjozwiak @cezaraugusto @bsclifton @NejcZdovc @LaurenWags @rossmoody @btlechowski