Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad notifications should timeout #2681

Closed
bridiver opened this issue Dec 21, 2018 · 1 comment · Fixed by brave/brave-core#1166
Closed

ad notifications should timeout #2681

bridiver opened this issue Dec 21, 2018 · 1 comment · Fixed by brave/brave-core#1166
Assignees
@bridiver
Labels
feature/ads OS/macOS OS/Windows QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@bridiver
Copy link
Contributor

bridiver commented Dec 21, 2018 •
edited
Loading

ad notification should timeout after 2 min in banner and alert style

  1. Trigger an ad notification - need link to instructions...
  2. Wait for at least 2 min
  3. notification should close without user input
@bridiver bridiver self-assigned this Dec 21, 2018
@bridiver bridiver mentioned this issue Dec 21, 2018
Merged
18 tasks
bridiver added a commit to brave/brave-core that referenced this issue Dec 21, 2018
@bridiver
ads should timeout after 2 min in both banner and alert style notific…
01966ec 
…ation preferences

fix brave/brave-browser#2681
@NejcZdovc NejcZdovc added this to the 0.59.x - Beta milestone Jan 2, 2019
@btlechowski
Copy link

btlechowski commented Jan 18, 2019 •
edited
Loading

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Notification was shown and "notificationType":"timeout" was logged after 2minutes of showing the notification

[7772:2056:0118/164558.750:INFO:ads_service_impl.cc(938)] AdsService Event Log: {"data":{"type":"notify","stamp":"2019-01-18T16:45:58Z","notificationType":"timeout",

Note: used iab.com and flags when testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
feature/ads OS/macOS OS/Windows QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

ads should timeout after 2 min in both banner and alert style notific… brave/brave-core
6 participants
@bridiver @tmancey @rebron @NejcZdovc @srirambv @btlechowski