Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor portfolio to show onscreen network selector and all assets #27333

Closed
Pavneet-Sing opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#17796
Closed

Refactor portfolio to show onscreen network selector and all assets #27333

Pavneet-Sing opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#17796
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Dec 13, 2022 •
edited
Loading

Description

  • Refactor portfolio to show onscreen network selector
  • Show assets per network or "All networks" selection

Expected result

Screenshot from 2022-12-13 16-07-37
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 13, 2022
@Pavneet-Sing Pavneet-Sing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 13, 2022
@Pavneet-Sing Pavneet-Sing moved this to Backlog in Web3 Dec 13, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Dec 13, 2022
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Progress in Web3 Dec 13, 2022
This was referenced Dec 13, 2022
Closed
Merged
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 15, 2023
Closed
25 tasks
This was referenced Mar 23, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 30, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 30, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.52.92 x64 Beta build

  • Verified steps from brave/brave-core#17796
  • Verified search token filters tokens based on selected network in portfolio
  • Verified tokens added via search token show up as expected
  • Encountered #30251
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27333-ARM.mp4
27333-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
3 participants
@Pavneet-Sing @srirambv @brave-builds