feat(wallet): Refactor network selector for multi chain #16350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavneet-Sing
added
CI/skip-linux
CI/skip-macos-x64
| .show(); | ||
| } | ||
| // Add little delay for smooth selection animation | ||
| new Handler().postDelayed(() -> { |
There was a problem hiding this comment.
please use chromium's wrappes for post tasks. Similar to this one https://source.chromium.org/chromium/chromium/src/+/main:android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java;l=442?q=WebViewContentsClientAdapter.java&ss=chromium%2Fchromium%2Fsrc
Pavneet-Sing
force-pushed
the
feat-network-selection-screen-multichain
branch
from
74d78fd to
458e500
Compare
Pavneet-Sing
force-pushed
the
feat-network-selection-screen-multichain
branch
from
8b01641 to
a62bc17
Compare
25 tasks
Pavneet-Sing
force-pushed
the
feat-network-selection-screen-multichain
branch
from
a62bc17 to
6af4648
Compare
- Add support for "All networks" option - Add support for independent network selection - Fix selection animation lag
Pavneet-Sing
force-pushed
the
feat-network-selection-screen-multichain
branch
from
6af4648 to
8ce6e11
Compare
|
Closing, merged via cloned PR #16355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27332
Resolves brave/brave-browser#23079
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
network-selector.webm
Additional info: