Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No cursor on "Send my tip" button #2744

Closed
jonathansampson opened this issue Dec 27, 2018 · 1 comment · Fixed by brave/brave-core#1189
Closed

No cursor on "Send my tip" button #2744

jonathansampson opened this issue Dec 27, 2018 · 1 comment · Fixed by brave/brave-core#1189
Assignees
@NejcZdovc
Labels
bug feature/rewards feature/user-interface All UI related good first issue QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.59.x - Release ...

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Dec 27, 2018 •
edited
Loading

Description

Reports that the Send my tip does not display a cursor: https://twitter.com/NinjaMaxR/status/1078111992420945921?s=19

Steps to Reproduce

  1. Hover Send my tip

Actual result:

No cursor displayed.

Expected result:

Hover should display pointer.

Reproduces how often:

TBD

Brave version (brave://version info)

TBD

Reproducible on current release:

TBD

Related Issues

#2705
@NejcZdovc NejcZdovc self-assigned this Dec 27, 2018
@NejcZdovc NejcZdovc mentioned this issue Dec 27, 2018
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 27, 2018
@NejcZdovc
Adds cursors to panel and site banner
62e31bf 
Resolves brave/brave-browser#2744
Resolves brave/brave-browser#2705
@NejcZdovc NejcZdovc added this to the 0.60.x - Dev milestone Dec 27, 2018
@kjozwiak kjozwiak added the QA/Yes label Jan 1, 2019
This was referenced Jan 14, 2019
Closed
Merged
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 14, 2019
@NejcZdovc
Adds cursors to panel and site banner
a89aff0 
Resolves brave/brave-browser#2744
@NejcZdovc NejcZdovc mentioned this issue Jan 14, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 0.59.x - Beta Jan 14, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 17, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10
  • Verified cursor on Send my tip

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards feature/user-interface All UI related good first issue QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds cursors to panel and site banner brave/brave-core
5 participants
@jonathansampson @kjozwiak @NejcZdovc @srirambv @GeetaSarvadnya