Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables SafeBrowsing on Android by default #27642

Closed
SergeyZhukovsky opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16540
Closed

Enables SafeBrowsing on Android by default #27642

SergeyZhukovsky opened this issue Jan 4, 2023 · 1 comment · Fixed by brave/brave-core#16540
Assignees
@SergeyZhukovsky
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/safebrowsing OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

We want to set the brave-safe-browsing flag to Enabled by default and keep it to be able to control the feature by Griffin.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jan 4, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 4, 2023
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jan 5, 2023
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.49.x - Nightly milestone Jan 6, 2023
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Feb 10, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 7, 2023 •
edited
Loading

Verified on the following devices using version 1.49.118 Chromium: 111.0.5563.50

Samsung GS 21 5G, Android 13
Samsung Tab S7, Android 12
Pixel 5 x86, Android 8

  • Ensured that Safe Browsing is enabled by default.
  • Ensured that disabling brave-safe-browsing flag will disable safe browsing using https://testsafebrowsing.appspot.com/
Example Example Example Example
screenshot-1678151047248 screenshot-1678151400004 screenshot-1678151451004 screenshot-1678151468603
Android 8 Android 8 Android 8 Android 8
Screen Shot 2023-03-06 at 8 32 45 PM Screen Shot 2023-03-06 at 8 34 47 PM Screen Shot 2023-03-06 at 8 36 23 PM Screen Shot 2023-03-06 at 8 38 16 PM
Example Example Example Example
screenshot-1678153345568 screenshot-1678153394818 screenshot-1678153431163 screenshot-1678153446876

This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/safebrowsing OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Enables Safe Browsing flag on Android by default brave/brave-core
4 participants
@fmarier @kjozwiak @SergeyZhukovsky @Uni-verse