Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Safe Browsing flag on Android by default #16540

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jan 5, 2023

Resolves brave/brave-browser#27642

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test site for Safe Browsing is https://testsafebrowsing.appspot.com/

  1. Make sure that Safe Browsing is working when you do a fresh install.
  2. Try to switch brave-safe-browsing to Disabled and check that Safe Browsing doesn't work.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 5, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 5, 2023
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmarier
Copy link
Member

fmarier commented Jan 6, 2023

Noting that we're keeping the flag as an emergency killswitch only.

@SergeyZhukovsky SergeyZhukovsky merged commit 0f33fe5 into master Jan 6, 2023
@SergeyZhukovsky SergeyZhukovsky deleted the android_safebrowsing_by_default branch January 6, 2023 19:17
@SergeyZhukovsky SergeyZhukovsky added this to the 1.49.x - Nightly milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enables SafeBrowsing on Android by default
3 participants