Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search engine default for IN #27709

Closed
rebron opened this issue Jan 9, 2023 · 5 comments · Fixed by brave/brave-core#16701
Closed

Update search engine default for IN #27709

rebron opened this issue Jan 9, 2023 · 5 comments · Fixed by brave/brave-core#16701
Assignees
@spylogsster @deeppandya
Labels
Brave Search OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Device-Types QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 9, 2023

Description

Update search engine default for India:

  • India (IN)

Brave should be at the top of the drop down list at brave://settings/search

Related: #18331, #23814, and #26181

Test plan

Region set to IN

  1. Fresh profile
  2. Default search engine SHOULD be Brave
  3. Visit brave://settings/searchEngines
  4. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX / BR / AR)

  1. Fresh profile
  2. Default will NOT be Brave Search
  3. Visit brave://settings/searchEngines
  4. Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Notes for test plan

#23814 (comment)
@anthonypkeane anthonypkeane mentioned this issue Jan 9, 2023
Closed
@spylogsster spylogsster mentioned this issue Jan 17, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 18, 2023
@deeppandya
Copy link

Thanku ou @spylogsster for working on this issue.
This issue doesn't have android onboarding changes. I will address it in a separate issue.

@spylogsster spylogsster removed the OS/Android Fixes related to Android browser functionality label Jan 20, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 17, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 17, 2023 •
edited
Loading

Verification Passed using

Brave | 1.49.101 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Test Case 1: Update search engine default for India - PASSED

Region/locale set to IN (India)

Case 1: - Fresh Install - PASSED

  1. Install 1.49.101
  2. launch Brave
  3. open a new tab page
  4. navigate to brave://settings/search
  5. confirmed Brave was selected as the default Search engine in the dropdown list for Normal window
  6. verified Brave was selected as the default Search engine in the dropdown list for Private Window as expected
  7. confirmed Brave was at the top of the Search engine dropdown list for Normal window
  8. verified Brave was at the top of the Search engine dropdown list for Private Window as expected
  9. open a new-tab and navigate to brave://settings/searchEngines
  10. confirmed Brave is shown as default and listed first in the Search engines list
  11. open a new tab enter brave in the URL bar
  12. confirmed Brave search results page shown as expected
step 5 - 6 step 7 step 8 step 9 step 12
image image image image image

Case 2: Upgrade - default SE: Google/Brave - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. verified Google was selected as the default Search engine in the dropdown list for Normal Window
  5. verified Brave was selected as the default Search engine in the dropdown list for Private Window
  6. open a new-tab page and navigate to brave://settings/searchEngines
  7. verified Brave is listed first in the Search engine list
  8. verified Google is shown as default and listed second in the list
  9. close the browser and upgrade to 1.49.101
  10. relaunch Brave
  11. open brave://settings/search
  12. confirmed Google was retained the drop down list as the default Search engine for Normal Window
  13. verified Brave was retained in the drop down list as the default Search engine for Private Window as expected
  14. confirmed Brave was at the top of the Search engine dropdown list for Normal window
  15. verified Brave was at the top of the Search engine dropdown list for Private window as expected
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Brave is retained and listed first in the in the Search engine list
  18. confirmed Google is retained as default and listed second in the Search engine list
  19. open brave://settings/search select Brave for Normal Window
  20. open a new tab and enter brave
  21. verified Brave search results page shown as expected
step 1 step 4-5 step 7-8 step 9 step 12-13 step 14 step 15 step 17-18 step 20 step 21
image image image image image image image image image image

Case 3: Upgrade - Modified SE: Bing/Qwant - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. selected Bing as the default Search engine in the dropdown list for Normal Window
  5. selected Qwant as the default Search engine in the dropdown list for Private Window
  6. open a new-tab page and navigate to brave://settings/searchEngines
  7. verified Brave is listed first in the Search engine list as expected
  8. verified Bing is shown as default in the Search engine list
  9. close the browser and upgrade to 1.49.101
  10. relaunch Brave
  11. open brave://settings/search
  12. confirmed Bing was retained the drop down list as the default Search engine for Normal Window
  13. confirmed Qwant was retained in the drop down list as the default Search engine for Private Window
  14. confirmed Brave was at the top of the Search engine dropdown list for Normal window
  15. confirmed Brave was at the top of the Search engine dropdown list for Private window
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Brave is retained and listed first in the in the Search engine list
  18. confirmed Bing is retained as default in the Search engine list
step 1 step 4-5 step 7-8 step 9 step 12-13 step 14 step 15 step 17-18
image image image image image image image image

Test Case 2: Brave SHOULD be first in the Default search engines list when Region set to anything else: (excluding CA / DE / FR / GB / US / AT / ES / MX / BR / AR) - PASSED

Region/locale set to KR (Korea)

Case 1: New profile - PASSED

  1. Install 1.49.101
  2. launch Brave
  3. open a new tab page
  4. navigate to brave://settings/search
  5. confirmed Google was selected as the default in the Search engine dropdown list for Normal window
  6. confirmed Brave was selected as the default in the Search engine dropdown list for Private window
  7. verified Brave was at the top of the Search engine dropdown list for Normal Window
  8. verified Brave was at the top of the Search engine dropdown list for Private Window
  9. open a new-tab page and navigate to brave://settings/searchEngines
  10. confirmed Brave is listed first in the Search engine list
  11. confirmed Google is shown as default and listed second in the list
  12. open brave://settings/search select Brave for Normal Window
  13. open a new tab enter brave in the URL bar
  14. confirmed Brave search results page shown as expected
step 5-6 step 7 step 8 step 10-11 step 12 step 14
image image image image image image

Case 2: Upgrade default SE: Google/Brave - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. verified Google was selected as the default Search engine in the dropdown list for Normal Window
  5. verified Brave was selected as the default Search engine in the dropdown list for Private Window
  6. open a new-tab page and navigate to brave://settings/searchEngines
  7. verified Brave is listed first in the Search engine list
  8. verified Google is shown as default and listed second in the list
  9. close the browser and upgrade to 1.49.101
  10. relaunch Brave
  11. open brave://settings/search
  12. confirmed Google was retained in the drop down list as the default Search engine for Normal Window
  13. verified Brave was retained in the drop down list as the default Search engine for Private Window as expected
  14. confirmed Brave was at the top of the Search engine dropdown list for Normal window
  15. verified Brave was at the top of the Search engine dropdown list for Private window as expected
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Brave is retained and listed first in the in the Search engine list
  18. confirmed Google is retained as default and listed second in the Search engine list
  19. open brave://settings/search select Brave for Normal Window
  20. open a new tab and enter brave in the URL bar
  21. verified Brave search results page shown as expected
step 1 step 4-5 step 7-8 step 9 step 12-13 step 14 step 15 step 17-18 step 20 step 21
image image image image image image image image image image

Case 3: Upgrade - Modified SE: Startpage/DuckDuckGo - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. selected Startpage as the default Search engine in the dropdown list for Normal Window
  5. selected DuckDuckGo as the default Search engine in the dropdown list for Private Window
  6. open a new-tab page and navigate to brave://settings/searchEngines
  7. verified Brave is listed first in the Search engine list as expected
  8. verified Startpage is shown as default in the Search engine list
  9. close the browser and upgrade to 1.49.101
  10. relaunch Brave
  11. open brave://settings/search
  12. confirmed Startpage was retained the drop down list as the default Search engine for Normal Window
  13. confirmed DuckDuckGo was retained in the drop down list as the default Search engine for Private Window
  14. confirmed Brave was at the top of the Search engine dropdown list for Normal window
  15. confirmed Brave was at the top of the Search engine dropdown list for Private window
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Brave is retained and listed first in the in the Search engine list
  18. confirmed Startpage is retained as default in the Search engine list
step 1 step 4-5 step 7-8 step 9 step 12-13 step 14 step 15 step 17-18
image image image image image image image image

Test Case 3: Brave is listed as second in the default search engines list for a region where Yandex is default

Region/locale set to RU (Russia)

Case 1: New profile - PASSED

  1. Install 1.49.101
  2. launch Brave
  3. open a new tab page
  4. navigate to brave://settings/search
  5. confirmed Yandex was selected as the default Search engine in the dropdown list for Normal Window
  6. confirmed Brave was selected as the default Search engine in the dropdown list for Private Window
  7. confirmed Brave listed second in the Search engine dropdown list for Normal window`
  8. open a new-tab page and navigate to brave://settings/searchEngines
  9. confirmed Brave is listed second in the Search engine list
  10. confirmed Yandex is shown as Default and listed first in the Search engine list
  11. open a new tab enter brave in the URL bar
  12. confirmed Yandex search results page shown as expected
step 5-6 step 7 step 9-10 step 12
image image image image

Case 2: Upgrade - Default SE: Yandex/Brave - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. verified Yandex was selected as the default Search engine in the dropdown list for Normal Window
  5. verified Brave was selected as the default Search engine in the dropdown list for Private Window
  6. verified Brave listed second in the Search engine dropdown list for Normal window``
  7. open a new-tab page and navigate to brave://settings/searchEngines
  8. verified Yandex is listed as default and first in the Search engine list as expected
  9. verified Brave is shown listed second in the list
  10. close the browser and upgrade to 1.49.101
  11. relaunch Brave
  12. open brave://settings/search
  13. confirmed Yandex was retained the drop down list as the default Search engine for Normal Window
  14. confirmed Brave was retained in the drop down list as the default Search engine for Private Window
  15. confirmed Brave listed second in the Search engine dropdown list for Normal window
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Yandex is retained as default and listed first in the in the drop down Search engine list
  18. confirmed Brave is retained listed second in the Search engine list
  19. open brave://settings/search select Brave for Normal Window
  20. verified brave is shown as default in brave://settings/searchEngines
  21. open a new tab and enter brave
  22. verified Brave search results page shown as expected
step 4-5 step 6 step 7-8 step 13-14 step 15 step 17-18 step 19 step 20 step 22
image image image image image image image image image

Case 3: Upgrade: Modified SE - Google/DuckDuckGo - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. selected Google as the default Search engine in the dropdown list for Normal Window
  5. selected DuckDuckGo as the default Search engine in the dropdown list for Private Window
  6. verified Yandex and Brave are listed first and second respectively for Normal Window
  7. open a new-tab page and navigate to brave://settings/searchEngines
  8. verified Yandex is listed first in the in the Search engine list
  9. verified Brave listed as second in the in the Search engine list
  10. verified Google is shown as default in the Search engine list
  11. close the browser and upgrade to 1.49.101
  12. relaunch Brave
  13. open brave://settings/search
  14. confirmed Google was retained the drop down list as the default Search engine for Normal Window
  15. confirmed DuckDuckGo was retained in the drop down list as the default Search engine for Private Window
  16. confirmed Yandex was still listed first in the the drop down list for Normal Window
  17. open a new-tab page and navigate to brave://settings/searchEngines
  18. confirmed Yandex was listed first in the in the drop down Search engine list as expected
  19. confirmed Brave is retained listed second in the Search engine list as expected
  20. confirmed Google is still retained as default and listed third in the Search engine list
step 4-5 step 6 step 8-10 step 14-15 step 16 step 18-20
image image image image image image

Test Case 4: Region set to CA / DE / FR / GB / US / AT / ES / MX / BR / AR where Brave is set as Default - PASSED

Region/locale set to US (United States)

Case 1: New Profile - PASSED

  1. Install 1.49.101
  2. launch Brave
  3. open a new tab page
  4. navigate to brave://settings/search
  5. verified Brave was selected as the default Search engine in the dropdown list for Normal window/Private Windows as expected
  6. verified Brave was selected as the default Search engine in the dropdown list for Private Window as expected
  7. verified Brave was at the top of the Search engine in the dropdown list for Normal window` as expected
  8. verified Brave was at the top of the Search engine in the dropdown list for Private Window as expected
  9. open a new-tab and navigate to brave://settings/searchEngines
  10. verified Brave is listed as default and shows first in the Search engines list as expected
  11. open a new tab page enter brave in the URL bar
  12. verified Brave search results page shown as expected
step 5-6 step 7 step 10 step 12
image image image image

Case 2: Upgrade - default SE Brave/Brave - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. verified Brave was selected as the default Search engine in the dropdown list for Normal Window
  5. verified Brave was selected as the default Search engine in the dropdown list for Private Window
  6. verified Brave was at the top of the Search engine in the dropdown list for Normal window
  7. open a new-tab page and navigate to brave://settings/searchEngines
  8. confirmed Brave is listed first as a default in the Search engine list
  9. close the browser and upgrade with 1.49.101
  10. relaunch Brave
  11. open brave://settings/search
  12. confirmed Brave was retained the drop down list as the default Search engine for Normal Window
  13. confirmed Brave was retained in the drop down list as the default Search engine for Private Window
  14. open a new-tab page and navigate to brave://settings/searchEngines
  15. confirmed Brave is retained as default and listed first in the in the Search engine list
  16. open a new tab page enter brave in the URL bar
  17. verified Brave search results page shown as expected
step 4-5 step 6 step 8 step 12-13 step 14-15 step 17
image image image image image image

Case 3: Upgrade - Modified SE Startpage/DuckDuckGo - PASSED

  1. Install 1.48.167
  2. launch Brave
  3. open brave://settings/search in a new-tab page
  4. selected Startpage as the default Search engine in the dropdown list for Normal Window
  5. selected DuckDuckGo as the default Search engine in the dropdown list for Private Window
  6. verified Brave is listed first in the dropdown list for Normal Window as expected
  7. open a new-tab page and navigate to brave://settings/searchEngines
  8. verified Brave listed first in the in the Search engine list
  9. verified Startpage listed as default in the Search engine list
  10. close the browser and upgrade to 1.49.101
  11. relaunch Brave
  12. open brave://settings/search
  13. confirmed Startpage was retained in the drop down list as the default Search engine for Normal Window
  14. confirmed DuckDuckGo was retained in the drop down list as the default Search engine for Private Window
  15. confirmed Brave was still listed first in the the drop down list for Normal Window
  16. open a new-tab page and navigate to brave://settings/searchEngines
  17. confirmed Brave was listed first in the in the drop down Search engine list as expected
  18. confirmed Startpage is retained as default and in the Search engine list as expected
step 4-5 step 6 step 8-9 step 13-14 step 15 step 18-19
image image image image image image

@LaurenWags
Copy link
Member

LaurenWags commented Feb 20, 2023 •
edited
Loading

Verified with

Brave | 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (x86_64)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | macOS Version 12.6.3 (Build 21G419)

Note, per #27709 (comment) have modeled the below based on #23814 (comment)

IN (India) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2023-02-20 at 2 58 53 PM Screenshot 2023-02-20 at 3 02 20 PM Screenshot 2023-02-20 at 3 02 29 PM Screenshot 2023-02-20 at 3 02 40 PM Screenshot 2023-02-20 at 3 02 58 PM
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for Normal Windows
  • changed Brave to Google for default SE for Private Windows
  • updated to 1.49.x and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 3 25 10 PM Screenshot 2023-02-20 at 3 26 32 PM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 3 26 44 PM Screenshot 2023-02-20 at 3 26 52 PM Screenshot 2023-02-20 at 3 27 03 PM
Updated Profile (Startpage/DDG - modified SE) - PASSED
  • installed 1.48.x
  • Selected Startpage as the default SE selected under brave://settings/search for Normal Windows
  • Left Brave as the default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal Windows = Startpage and Private Windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 3 44 20 PM Screenshot 2023-02-20 at 3 44 42 PM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 3 45 00 PM Screenshot 2023-02-20 at 3 45 07 PM Screenshot 2023-02-20 at 3 45 17 PM
  • Install 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Brave is default for Private windows
  • Change the SE to Startpage in Normal windows SE dropdown
  • Change the SE to DDG in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that Startpage was the default SE selected under brave://settings/search for Normal windows
  • Ensured that DDG was the default SE selected under brave://settings/search for Private windows
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 3 47 38 PM Screenshot 2023-02-20 at 3 48 04 PM
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 3 48 12 PM Screenshot 2023-02-20 at 3 48 19 PM Screenshot 2023-02-20 at 3 48 31 PM
Updated Profile (Bing/Qwant - modified SE) - PASSED
  • installed 1.48.x
  • Selected Bing as the default SE selected under brave://settings/search
  • Left Brave as the default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for Normal and Private windows
    • Normal Windows = Bing and Private Windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 4 00 00 PM Screenshot 2023-02-20 at 4 00 30 PM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 4 00 39 PM Screenshot 2023-02-20 at 4 00 46 PM Screenshot 2023-02-20 at 4 00 55 PM
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE for Normal windows
  • Ensured Brave is the default SE for Private windows
  • Change the SE to Bing in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.49.x
  • Ensured that Bing was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 4 04 32 PM Screenshot 2023-02-20 at 4 05 02 PM
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 4 05 17 PM Screenshot 2023-02-20 at 4 05 24 PM Screenshot 2023-02-20 at 4 05 34 PM

Confirmed that one locale from CA / DE / FR / GB / US / AT / ES / MX / BR / AR (regions with Brave as default) is working as expected.

FR (France) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screenshot 2023-02-20 at 16 16 37 Screenshot 2023-02-20 at 16 17 12 Screenshot 2023-02-20 at 16 17 19 Screenshot 2023-02-20 at 16 17 26 Screenshot 2023-02-20 at 16 17 36
Updated Profile (Brave/Brave - default SE) - PASSED
  • installed 1.48.x
  • ensured that Brave was the default SE selected under brave://settings/search
  • updated to 1.49.x and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-20 at 16 30 24 Screenshot 2023-02-20 at 16 30 53
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-20 at 16 31 06 Screenshot 2023-02-20 at 16 31 13 Screenshot 2023-02-20 at 16 31 21
Updated Profile (DDG/Startpage - modified SE) - PASSED
  • installed 1.48.x
  • Selected DDG was the default SE selected under brave://settings/searchEngines for Normal windows and left Brave as default SE for private windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = DDG and Private windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-21 at 12 44 54 Screenshot 2023-02-21 at 12 45 18
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-21 at 12 45 26 Screenshot 2023-02-21 at 12 45 34 Screenshot 2023-02-21 at 12 45 43
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Brave is the default SE in both Normal and Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Startpage in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Startpage was the default SE selected under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.100 Chromium: 110.0.5481.100
Screenshot 2023-02-21 at 12 47 32 Screenshot 2023-02-21 at 12 48 01
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-21 at 12 48 08 Screenshot 2023-02-21 at 12 48 15 Screenshot 2023-02-21 at 12 48 26 
Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (x86_64)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | macOS Version 12.6.3 (Build 21G419)

Checking to ensure that one locale that doesn't have Brave Search as the default (as listed in description) or doesn't have Yandex as default (as noted in #12327) is working as expected.

FI (Finland) locale

Clean Profile - PASSED
  • ensured that Google was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Google was selected as the default via brave://settings/searchEngines and Brave was listed first
Example Example Example Example Example
Screenshot 2023-02-21 at 15 44 59 Screenshot 2023-02-21 at 15 45 15 Screenshot 2023-02-21 at 15 45 24 Screenshot 2023-02-21 at 15 45 32 Screenshot 2023-02-21 at 15 45 43
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for normal windows
  • changed default SE for Private windows from Brave to Google
  • updated to 1.49.x and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screenshot 2023-02-21 at 16 06 58 Screenshot 2023-02-21 at 16 12 00
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-21 at 16 13 26 Screenshot 2023-02-21 at 16 13 33 Screenshot 2023-02-21 at 16 13 43
Updated Profile (Qwant/Bing - modified SE) - PASSED
  • installed 1.48.x
  • selected Qwant as the default SE selected under brave://settings/search for Normal Windows, left Brave as default SE for Private windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = Qwant and Private windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screenshot 2023-02-21 at 16 30 31 Screenshot 2023-02-21 at 16 31 09
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-21 at 16 31 18 Screenshot 2023-02-21 at 16 31 24 Screenshot 2023-02-21 at 16 31 32
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE in both Normal and Brave is the default SE for Private windows
  • Change the SE to Qwant in Normal windows SE dropdown
  • Change the SE to Bing in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that Qwant was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Bing was the default SE selected under brave://settings/search for Private windows
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screenshot 2023-02-21 at 16 43 05 Screenshot 2023-02-21 at 16 43 24
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screenshot 2023-02-21 at 16 43 30 Screenshot 2023-02-21 at 16 43 37 Screenshot 2023-02-21 at 16 43 45

Checking to ensure that a locale that has Yandex as the default (per #12327) is working as expected.

Uzbekistan locale

Clean Profile - PASSED
  • ensured that Yandex was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screen Shot 2023-02-23 at 14 25 10 Screen Shot 2023-02-23 at 14 25 24 Screen Shot 2023-02-23 at 14 25 32 Screen Shot 2023-02-23 at 14 25 40 Screen Shot 2023-02-23 at 14 25 48
Updated Profile (Yandex/Yandex) - PASSED
  • installed 1.48.x
  • ensured that Yandex was the default SE selected under brave://settings/search for Normal Windows
  • selected Yandex as the default SE for Private Windows (was Brave)
  • updated to 1.49.x and ensured that Yandex is still the default SE in both Normal and Private window SE
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows and Brave is listed second
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screen Shot 2023-02-23 at 14 32 53 Screen Shot 2023-02-23 at 14 33 20
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-02-23 at 14 33 26 Screen Shot 2023-02-23 at 14 33 31 Screen Shot 2023-02-23 at 14 33 39
Updated Profile (DDG/Qwant) - PASSED
  • installed 1.48.x
  • selected DDG as the default SE for Normal Windows under brave://settings/search, left Brave as default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = DDG and Private Windows = Brave
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screen Shot 2023-02-23 at 14 35 21 Screen Shot 2023-02-23 at 14 35 45
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-02-23 at 14 35 51 Screen Shot 2023-02-23 at 14 35 57 Screen Shot 2023-02-23 at 14 36 04
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Yandex is the default SE in both Normal and Brave is the Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
1.48.164 Chromium: 110.0.5481.100 1.49.106 Chromium: 110.0.5481.104
Screen Shot 2023-02-23 at 14 39 11 Screen Shot 2023-02-23 at 14 39 46
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-02-23 at 14 39 53 Screen Shot 2023-02-23 at 14 40 00 Screen Shot 2023-02-23 at 14 40 11

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 21, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 21, 2023
@deeppandya deeppandya mentioned this issue Feb 21, 2023
Closed
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 23, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Mar 1, 2023 •
edited
Loading

Verified with

Brave	1.49.114 Chromium: 110.0.5481.177 (आधिकारिक बिल्ड) beta (64-बिट) 
पुनरीक्षण	f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS	Linux

Note, per #27709 (comment) have modeled the below based on #23814 (comment)

IN (India) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
1 2 3 4 5
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for Normal Windows
  • changed Brave to Google for default SE for Private Windows
  • updated to 1.49.x and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 9 27 34 AM Screen Shot 2023-03-01 at 9 28 42 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 9 28 48 AM Screen Shot 2023-03-01 at 9 28 56 AM Screen Shot 2023-03-01 at 9 29 03 AM
Updated Profile (Startpage/DDG - modified SE) - PASSED
  • installed 1.48.x
  • Selected Startpage as the default SE selected under brave://settings/search for Normal Windows
  • Left Brave as the default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal Windows = Startpage and Private Windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 9 35 14 AM Screen Shot 2023-03-01 at 9 36 04 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 9 36 13 AM Screen Shot 2023-03-01 at 9 36 19 AM Screen Shot 2023-03-01 at 9 36 26 AM
  • Install 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE for both Normal and Brave is default for Private windows
  • Change the SE to Startpage in Normal windows SE dropdown
  • Change the SE to DDG in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that Startpage was the default SE selected under brave://settings/search for Normal windows
  • Ensured that DDG was the default SE selected under brave://settings/search for Private windows
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 10 56 14 AM Screen Shot 2023-03-01 at 10 56 36 AM
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 10 56 42 AM Screen Shot 2023-03-01 at 10 56 49 AM Screen Shot 2023-03-01 at 10 56 57 AM
Updated Profile (Bing/Qwant - modified SE) - PASSED
  • installed 1.48.x
  • Selected Bing as the default SE selected under brave://settings/search
  • Left Brave as the default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for Normal and Private windows
    • Normal Windows = Bing and Private Windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 11 10 35 AM Screen Shot 2023-03-01 at 11 11 19 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 11 11 25 AM Screen Shot 2023-03-01 at 11 11 33 AM Screen Shot 2023-03-01 at 11 11 43 AM
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE for Normal windows
  • Ensured Brave is the default SE for Private windows
  • Change the SE to Bing in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Rename the profile to Release channel and upgrade the profile to 1.49.x
  • Ensured that Bing was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 11 13 11 AM Screen Shot 2023-03-01 at 11 13 51 AM
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 11 13 57 AM Screen Shot 2023-03-01 at 11 14 03 AM Screen Shot 2023-03-01 at 11 14 10 AM

Confirmed that one locale from CA / DE / FR / GB / US / AT / ES / MX / BR / AR (regions with Brave as default) is working as expected.

CA (Canada) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screen Shot 2023-03-01 at 11 21 31 AM Screen Shot 2023-03-01 at 11 22 30 AM Screen Shot 2023-03-01 at 11 22 37 AM Screen Shot 2023-03-01 at 11 22 43 AM Screen Shot 2023-03-01 at 11 22 50 AM
Updated Profile (Brave/Brave - default SE) - PASSED
  • installed 1.48.x
  • ensured that Brave was the default SE selected under brave://settings/search
  • updated to 1.49.x and ensured that Brave is still the default SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 11 31 46 AM Screen Shot 2023-03-01 at 11 32 40 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 11 32 46 AM Screen Shot 2023-03-01 at 11 32 53 AM Screen Shot 2023-03-01 at 11 33 00 AM
Updated Profile (DDG/Startpage - modified SE) - PASSED
  • installed 1.48.x
  • Selected DDG was the default SE selected under brave://settings/searchEngines for Normal windows and left Brave as default SE for private windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = DDG and Private windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 11 47 01 AM Screen Shot 2023-03-01 at 11 47 28 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 11 47 35 AM Screen Shot 2023-03-01 at 11 47 48 AM Screen Shot 2023-03-01 at 11 47 56 AM
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Brave is the default SE in both Normal and Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Startpage in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Startpage was the default SE selected under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 11 50 13 AM Screen Shot 2023-03-01 at 11 50 55 AM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 11 51 01 AM Screen Shot 2023-03-01 at 11 51 09 AM Screen Shot 2023-03-01 at 11 51 16 AM

Checking to ensure that one locale that doesn't have Brave Search as the default (as listed in description) or doesn't have Yandex as default (as noted in #12327) is working as expected.

Australia locale

Clean Profile - PASSED
  • ensured that Google was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Google was selected as the default via brave://settings/searchEngines and Brave was listed first
Example Example Example Example Example
Screen Shot 2023-03-01 at 12 45 27 PM Screen Shot 2023-03-01 at 12 45 38 PM Screen Shot 2023-03-01 at 12 45 46 PM Screen Shot 2023-03-01 at 12 45 53 PM Screen Shot 2023-03-01 at 12 46 00 PM
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for normal windows
  • changed default SE for Private windows from Brave to Google
  • updated to 1.49.x and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 12 51 34 PM Screen Shot 2023-03-01 at 12 52 07 PM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 12 52 14 PM Screen Shot 2023-03-01 at 12 52 21 PM Screen Shot 2023-03-01 at 12 52 28 PM
Updated Profile (Qwant/Bing - modified SE) - PASSED
  • installed 1.48.x
  • selected Qwant as the default SE selected under brave://settings/search for Normal Windows, left Brave as default SE for Private windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = Qwant and Private windows = Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 1 18 38 PM Screen Shot 2023-03-01 at 1 19 06 PM
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 1 19 12 PM Screen Shot 2023-03-01 at 1 19 18 PM Screen Shot 2023-03-01 at 1 19 24 PM
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Google is the default SE in both Normal and Brave is the default SE for Private windows
  • Change the SE to Qwant in Normal windows SE dropdown
  • Change the SE to Bing in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that Qwant was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Bing was the default SE selected under brave://settings/search for Private windows
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 1 21 07 PM Screen Shot 2023-03-01 at 1 23 03 PM
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
Example (Brave at top of list) Example (Brave at top of list) Example (Brave at top of list)
Screen Shot 2023-03-01 at 1 23 09 PM Screen Shot 2023-03-01 at 1 23 16 PM Screen Shot 2023-03-01 at 1 23 39 PM

Checking to ensure that a locale that has Yandex as the default (per #12327) is working as expected.

Belarus locale

Clean Profile - PASSED
  • ensured that Yandex was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was selected as the default via brave://settings/searchEngines
Example Example Example Example Example
Screen Shot 2023-03-01 at 1 35 01 PM Screen Shot 2023-03-01 at 1 35 33 PM Screen Shot 2023-03-01 at 1 35 40 PM Screen Shot 2023-03-01 at 1 35 48 PM Screen Shot 2023-03-01 at 1 35 56 PM
Updated Profile (Yandex/Yandex) - PASSED
  • installed 1.48.x
  • ensured that Yandex was the default SE selected under brave://settings/search for Normal Windows
  • selected Yandex as the default SE for Private Windows (was Brave)
  • updated to 1.49.x and ensured that Yandex is still the default SE in both Normal and Private window SE
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave was listed second on the list under brave://settings/search for Private windows and Brave is listed second
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 3 46 26 PM Screen Shot 2023-03-01 at 3 46 54 PM
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-03-01 at 3 47 00 PM Screen Shot 2023-03-01 at 3 47 07 PM Screen Shot 2023-03-01 at 3 47 16 PM
Updated Profile (DDG/Qwant) - PASSED
  • installed 1.48.x
  • selected DDG as the default SE for Normal Windows under brave://settings/search, left Brave as default SE for Private Windows
  • updated to 1.49.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal windows = DDG and Private Windows = Brave
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 3 49 42 PM Screen Shot 2023-03-01 at 3 50 33 PM
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-03-01 at 3 50 40 PM Screen Shot 2023-03-01 at 3 50 47 PM Screen Shot 2023-03-01 at 3 50 55 PM
  • Install version 1.48.x
  • Open brave://settings/search and ensure that Yandex is the default SE in both Normal and Brave is the Private window SE
  • Change the SE to DDG in Normal windows SE dropdown
  • Change the SE to Qwant in Private windows SE dropdown
  • Upgrade the profile to 1.49.x
  • Ensured that DDG was the default SE selected under brave://settings/search for Normal windows
  • Ensured that Qwant was the default SE selected under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
1.48.171 Chromium: 110.0.5481.177 1.49.114 Chromium: 110.0.5481.177
Screen Shot 2023-03-01 at 3 52 42 PM Screen Shot 2023-03-01 at 3 53 12 PM
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Normal windows
  • ensured that Yandex was the first engine via the drop down, Brave is displayed second on the list under brave://settings/search for Private windows
  • ensured that Yandex was the first engine via the list under brave://settings/searchEngines and Brave is listed second
Example (Yandex at top of list) Example (Yandex at top of list) Example (Yandex at top of list)
Screen Shot 2023-03-01 at 3 53 22 PM Screen Shot 2023-03-01 at 3 53 29 PM Screen Shot 2023-03-01 at 3 53 35 PM

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 1, 2023
@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Mar 17, 2023 •
edited
Loading

We shouldn't have removed OS/Android from the above as this was also implemented on Android. Thankfully it was partially verified via #28656 (comment) on OS/Android. @spylogsster please don't remove OS labels in the future if you're not sure. QA or the release team can always remove it if not applicable. On Android, it was basically split into two issues. The above re: adding Brave as the default and then the removal of the onboarding via #28656.

@kjozwiak kjozwiak added the OS/Android Fixes related to Android browser functionality label Mar 17, 2023
@rebron rebron mentioned this issue Apr 5, 2023
Closed
5 tasks
This was referenced May 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

@deeppandya deeppandya

Labels
Brave Search OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Device-Types QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Set Brave as default for India brave/brave-core
8 participants
@stephendonner @kjozwiak @spylogsster @deeppandya @rebron @LaurenWags @brave-builds @MadhaviSeelam