-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IPFS Kubo to 0.18.1 #27965
Closed
lidel opened this issue
Jan 23, 2023
· 1 comment
· Fixed by brave/brave-core-crx-packager#559 or brave/brave-core-crx-packager#574
Closed
Update IPFS Kubo to 0.18.1 #27965
lidel opened this issue
Jan 23, 2023
· 1 comment
· Fixed by brave/brave-core-crx-packager#559 or brave/brave-core-crx-packager#574
Labels
feature/web3/ipfs
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
release-notes/exclude
Milestone
Comments
bbondy
added
feature/web3/ipfs
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Jan 23, 2023
Binaries are ready: |
cypt4
added a commit
to brave/brave-core-crx-packager
that referenced
this issue
Feb 2, 2023
cypt4
added a commit
to brave/brave-core-crx-packager
that referenced
this issue
Feb 7, 2023
cypt4
added a commit
to brave/brave-core-crx-packager
that referenced
this issue
Feb 7, 2023
cypt4
added a commit
to brave/brave-core-crx-packager
that referenced
this issue
Feb 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/ipfs
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
release-notes/exclude
Release Notes: https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.18.md
Signed Binaries (MacOS): https://dist.ipfs.tech/kubo/v0.18.0/
This release introduces some configuration changes, and runs a migration on a preexisting repository to apply changes automatically to users who have default settings.
This means Brave, having some custom config overrides, needs to update some hardcoded config.
Necessary Config Updates
(1) Enable UDP transports (QUIC and WebTransport)
Brave runs with hardcoded TCP transport on port
45001
Modern QUIC transport runs on top of UDP. Whenever possible, QUIC will be preferred by IPFS peers over TCP. Not only is it faster, it also increases the chances of a successful holepunch in case of firewalls. It also enables WebTransport over QUIC.
To enable both, brave should update ipfs_service_utils.cc#L46-L50 and add QUIC UDP listeners on the same port as TCP:
(we only add
/quic-v1
because Brave had no/quic
before)(2) Remove custom ConnMgr limits
Custom limits from ipfs_service_utils.cc#L52-L54 should be removed:
Kubo 0.18 ships with sensible defaults (ipfs/kubo#9483) and we want Brave to benefit from ResourceMgr autoscaling features.
(3) Switch
Routing.Type
toauto
Automatic migration will replace
Routing.Type=dht
withRouting.Type=auto
. No action needed here.However, Brave has an additional override which we may consider removing.
Things are much smarter now, users who are behind NAT will remain DHT clients, and we also want Brave users to leverage IPNI router at https://cid.contact (which is enabled in
auto
mode).Due to this, we need to remove
--routing=dhtclient
CLI override from ipfs_service_impl.cc:- args.AppendArg("--routing=dhtclient");
This will switch to
Routing.Type
toauto
from config.The text was updated successfully, but these errors were encountered: