Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widgets components from manifest #28118

Closed
deeppandya opened this issue Jan 28, 2023 · 1 comment · Fixed by brave/brave-core#16904
Closed

Remove widgets components from manifest #28118

deeppandya opened this issue Jan 28, 2023 · 1 comment · Fixed by brave/brave-core#16904

Comments

@deeppandya
Copy link

deeppandya commented Jan 28, 2023

This issue is to remove widgets components from android manifest. We need to add a patch to remove the components.

This was the suggestion from Samsung team,

[Suggested Solution]

  1. delete widget component in Android manifest

image

@kjozwiak
Copy link
Member

kjozwiak commented Jan 29, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.188 Chromium: 109.0.5414.119 (Official Build) (32-bit)
--- | ---
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Android 13; Build/TQ1A.230105.002

Test Case #1 - Clean Profile/Install

  • ensured that the widget onboarding appeared/displayed without any issues
  • ensured that you can add a widget to the home screen via onboarding
  • ensured that there's 5 widgets that are appearing under Brave
  • ensured that you can add each widget onto the home screen without any issues
Example Example Example Example Example
Screenshot_20230129-023742 Screenshot_20230129-023747 Screenshot_20230129-023530 Screenshot_20230129-023536 Screenshot_20230129-024356

Test Case #2 - Upgrade from 1.47.186 -> 1.47.188 (Post #27757)

  • installed 1.47.186 and ensured that Brave only had three available widgets
  • added the three available widgets onto the home screen
  • updated to 1.47.188 and ensured that the previously added widgets are still working as expected
  • ensured that there's now 5 widgets appearing within the OS Widget section
  • ensured that you can add the older widgets onto the home screen without any issues

1.47.186 - Before Update

Example Example
Screenshot_20230129-025225 Screenshot_20230129-025335

1.47.188 - After Update

Example Example Example
Screenshot_20230129-025403 Screenshot_20230129-025409 Screenshot_20230129-025521

Test Case #3 - Upgrade from 1.47.172 -> 1.47.188 (Pre #27757)

  • installed 1.47.172 and ensured that Brave had four available widgets
  • added the four available widgets onto the home screen
  • updated to 1.47.188 and ensured that the previously added widgets are still working as expected
  • ensured that there's now 5 widgets appearing within the OS Widget section
  • ensured that you can add the older widgets onto the home screen without any issues

1.47.172 - Before Update

Example Example
Screenshot_20230129-030120 Screenshot_20230129-030239

1.47.188 - After Update

Example Example Example
Screenshot_20230129-030407 Screenshot_20230129-030659 Screenshot_20230129-030720

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.47.188 Chromium: 109.0.5414.119 (Official Build) (32-bit)
--- | ---
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Android 12; Build/SP1A.210812.016

Test Case #1 - Clean Profile/Install

  • ensured that the widget onboarding appeared/displayed without any issues
  • ensured that you can add a widget to the home screen via onboarding
  • ensured that there's 5 widgets that are appearing under Brave
  • ensured that you can add each widget onto the home screen without any issues
Example Example Example Example
Screenshot_20230129-032748_Brave Screenshot_20230129-032808_One UI Home Screenshot_20230129-032814_One UI Home Screenshot_20230129-033044_One UI Home

Test Case #2 - Upgrade from 1.47.186 -> 1.47.188 (Post #27757)

  • installed 1.47.186 and ensured that Brave only had three available widgets
  • added the three available widgets onto the home screen
  • updated to 1.47.188 and ensured that the previously added widgets are still working as expected
  • ensured that there's now 5 widgets appearing within the OS Widget section
  • ensured that you can add the older widgets onto the home screen without any issues

1.47.186 - Before Update

Example Example
Screenshot_20230129-035614_One UI Home Screenshot_20230129-035724_One UI Home

1.47.188 - After Update

Example Example Example
Screenshot_20230129-035840_One UI Home Screenshot_20230129-035845_One UI Home Screenshot_20230129-035946_One UI Home

Test Case #3 - Upgrade from 1.46.154 -> 1.47.188 (Pre #27757)

  • installed 1.46.154`` and ensured that Brave` had four available widgets
  • added the four available widgets onto the home screen
  • updated to 1.47.188 and ensured that the previously added widgets are still working as expected
  • ensured that there's now 5 widgets appearing within the OS Widget section
  • ensured that you can add the older widgets onto the home screen without any issues

1.46.154 - Before Update

Example Example Example
Screenshot_20230129-040939_One UI Home Screenshot_20230129-040948_One UI Home Screenshot_20230129-041056_One UI Home

1.47.188 - After Update

Example Example Example
Screenshot_20230129-041350_One UI Home Screenshot_20230129-041355_One UI Home Screenshot_20230129-041432_One UI Home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants