Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old widgets are not removed in widget list on upgraded profile #27757

Closed
Uni-verse opened this issue Jan 11, 2023 · 3 comments · Fixed by brave/brave-core#16744
Closed

Old widgets are not removed in widget list on upgraded profile #27757

Uni-verse opened this issue Jan 11, 2023 · 3 comments · Fixed by brave/brave-core#16744

Comments

@Uni-verse
Copy link
Contributor

Description

Old widgets are not removed in widget list on upgraded profile

Steps to reproduce

  1. Install 1.46.x
  2. Launch Brave
  3. Add brave quick action widget on home screen
  4. Upgrade to 1.47.x
  5. Attempt to add another widget from home screen long press.
  6. Observe list of widgets under brave

Actual result

Brave shows list of 5 widgets, 2 of them are legacy widgets (dino, and original search widget)

Example Example
screenshot-1673458004884 screenshot-1673458013478

Expected result

  1. Old widgets should be removed. The list should show 3 widgets like you would see with a fresh profile.
  2. Existing search widget should be updated to new version.

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 12

Brave version

1.47.169, Chromium 109.0.5414.87

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality feature/widgets labels Jan 11, 2023
@timchilds
Copy link

Upgrade old widgets to newer version of widget after Brave is updated. @deeppandya

@kjozwiak
Copy link
Member

The above requires 1.47.179 or higher for 1.47.x verification 👍

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jan 23, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014

Test Plan: #27757 (comment)

  • Verified brave widget count is updated to 3 from 4 widgets on existing profile
  • Verified legacy quick action widget is updated to new widget
  • Verified dino widget is removed from list
1.46.154 1.46.154 1.47.181 1.47.181
screenshot-1674497428220 screenshot-1674497476681 screenshot-1674497652015 screenshot-1674497662577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants