Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave can't change to another language on Android 13 #28822

Closed
ChowMein47 opened this issue Mar 1, 2023 · 20 comments · Fixed by brave/brave-core#22814
Closed

Brave can't change to another language on Android 13 #28822

ChowMein47 opened this issue Mar 1, 2023 · 20 comments · Fixed by brave/brave-core#22814
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected Android 13 Impacting Android 13 devices bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@ChowMein47
Copy link

ChowMein47 commented Mar 1, 2023

Description

Currently my phone default language is English. I want to change brave language to Indonesian but can't change it and it always reverts to English following the device default language

Steps to reproduce

  1. Open Brave
  2. Go to settings, choose languages and set to another language
  3. Restart

Actual result

Still stuck in English following current device language

Expected result

The language should be change after restart Brave Browser

Issue reproduces how often

easily

Version/Channel Information:

I tested on Stable
  • Can you reproduce this issue with the current Play Store version? YES
  • Can you reproduce this issue with the current Play Store Beta version? -
  • Can you reproduce this issue with the current Play Store Nightly version?-

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Realme 9 Pro
  • Android version: 13

Brave version: Brave 1.59.117, Chromium 118.0.5993.70

@ChowMein47 ChowMein47 added the OS/Android Fixes related to Android browser functionality label Mar 1, 2023
@ChowMein47 ChowMein47 changed the title Brave can't set to another language on Android 13 Brave can't chabge to another language on Android 13 Mar 2, 2023
@ChowMein47 ChowMein47 changed the title Brave can't chabge to another language on Android 13 Brave can't change to another language on Android 13 Mar 7, 2023
@ChowMein47
Copy link
Author

@srirambv can you check this plz?

@apolymen
Copy link

Same here.
Android 13, phone language Greek, changing Brave language to English reverts back to Greek after restart.

@timchilds timchilds added bug Android 13 Impacting Android 13 devices labels Apr 28, 2023
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 3, 2023
@ChowMein47
Copy link
Author

@deeppandya any update?

@Pf-16
Copy link

Pf-16 commented Jul 17, 2023

I am also having the same issue on Android 13 on version 1.52.130

@TheWranger
Copy link

Same issue on 1.57.53

@ChowMein47
Copy link
Author

Please fix this bug

@jagdishveera
Copy link

Hello,
This issue is specific to Android 13 OS and is working fine in other OS.
Issue is happening because android added new feature Per-app language preferences and only that app which are added in language section will be able to change the language.
May you please fix this issue as language change is not working in my device.
Thanks

@FelipeTankian
Copy link

Hi, i have the same issue here on
Brave 1.60.125, Chromium 119.0.6045.199
for a device
Samsung SM-G985F,
exynos990,
Android 13 (Build/TP1A.220624.014).

@deeppandya deeppandya assigned deeppandya and unassigned tapanmodh Jan 9, 2024
@ChowMein47
Copy link
Author

This bug almost a year still not fixed. Kiwi browser dev already fixed this issue a few months ago

@deeppandya
Copy link

deeppandya commented Feb 20, 2024

Hey guys, just want to give you an update on the issue. I am actively looking into it. And planning to include the fix for the 1.65 release. Please stay tuned for the update.

@deeppandya
Copy link

@ChowMein47 @FelipeTankian @jagdishveera we have resolved the issue in latest nightly.

@brave-builds brave-builds added this to the 1.64.x - Release #4 milestone Apr 9, 2024
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Apr 9, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Apr 9, 2024

The above requires 1.64.120 or higher for 1.64.x verification 👍 @Uni-verse @hffvld lets make sure that the above hasn't regressed older Android versions (Android 12 or lower including Android 8).

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.64.122 Chromium: 123.0.6312.122 (Official Build) (64-bit) 
Revision	a5b964f45dca7b87fc0f2adf2660d6fd6a6608b8
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Steps to Reproduce in #28822 (comment):

  • Ensured language is not changed after switching to another language and restarting.
  • Ensured changing back to default language works.
Example Example Example
Screenshot 2024-04-11 at 10 21 24 AM Screenshot 2024-04-11 at 10 22 14 AM Screenshot 2024-04-11 at 10 22 27 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.64.122 Chromium: 123.0.6312.122 (Official Build) (64-bit) 
Revision	a5b964f45dca7b87fc0f2adf2660d6fd6a6608b8
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Steps to Reproduce in #28822 (comment):

  • Ensured language is not changed after switching to another language and restarting on fresh and upgraded profiles.
  • Ensured changing back to default language works.
Example Example
Screenshot 2024-04-11 at 10 30 40 AM Screenshot 2024-04-11 at 10 31 32 AM

@hffvld
Copy link
Contributor

hffvld commented Apr 11, 2024

Verified on Pixel 2 XL using version(s):

Device/OS: Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
Brave build: 1.66.70
Chromium: 124.0.6367.29 (Official Build) canary (64-bit)

STEPS:

  1. Followed the steps from Brave can't change to another language on Android 13  #28822 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that 2 different languages can be set for the device and Brave separately
  • Verified that the language set in Brave is not changed back to a device language after Brave restart

timestamp_10-05-41_10-09-43.1.mov

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 2 XL running Android 11 using the following build(s):

Brave | 1.64.122 Chromium: 123.0.6312.122 (Official Build) (64-bit)
-- | --
Revision | a5b964f45dca7b87fc0f2adf2660d6fd6a6608b8
OS | Android 11; Build/RP1A.201005.004.A1; 30; REL
Example Example Example
Screenshot_20240411-172243 Screenshot_20240411-172305 Screenshot_20240411-172315

@jagdishjnu08
Copy link

jagdishjnu08 commented Sep 3, 2024

OS : Android 14
Before this fix , it was asking for restart of the browser.
Now the brave setting fragment is getting restart and it does not ask for restart the browser.
Just a question.
Is this change in behavior okay?
Thanks

@bsclifton
Copy link
Member

cc: @deeppandya on above question

@deeppandya
Copy link

@jagdishjnu08 it would ask you to restart the app if the selected language is not available to switch right away. if you are using a new language, it would fetch the language package and ask you to restart the app to apply the change.

@jagdishjnu08
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected Android 13 Impacting Android 13 devices bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.