Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Transak onramp, assets are showing up that are not supported for US users #28866

Closed
HEagle18 opened this issue Mar 2, 2023 · 4 comments
Closed
Assignees
Labels

Comments

@HEagle18
Copy link

HEagle18 commented Mar 2, 2023

Description

With Transak, there is an asset list for global users and then an asset list for US users. Here is the list https://docs.transak.com/docs/on-ramp-crypto-currency-coverage. right now we are showing the global list to all users.

See conversation here https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1677758889153949

We need to find a way to show only assets that are support for US users to users that have selected USD currency.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added bug OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 2, 2023
@muliswilliam muliswilliam self-assigned this Mar 3, 2023
@muliswilliam muliswilliam added release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Mar 3, 2023
@muliswilliam
Copy link

This was fixed here: brave/brave-core#17773

@srirambv
Copy link
Contributor

@muliswilliam Please add appropriate QA label for this. Adding it to 1.51.x as the linked PR is set for that milestone

@srirambv srirambv added this to the 1.51.x - Beta milestone Apr 20, 2023
@rebron rebron changed the title for Transak onramp, assets are showing up that are not supported for US users For Transak onramp, assets are showing up that are not supported for US users Apr 26, 2023
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Apr 27, 2023
@srirambv
Copy link
Contributor

srirambv commented May 2, 2023

Verification passed on

Brave 1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • tokens that only had Transak as provider is not shown in the asset list on Buy screen.
28866.mp4

@srirambv
Copy link
Contributor

srirambv commented May 3, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.51.109 x64 build

  • Verified Transak is shown only for supported tokens in the US
28866.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants