Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Remove Transak assets unsupported in US #17773

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#29334

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [
    -[x] Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@cypt4 cypt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@muliswilliam muliswilliam merged commit de736d8 into master Mar 28, 2023
@muliswilliam muliswilliam deleted the remove-transak-assets-not-supported-in-us branch March 28, 2023 11:24
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 28, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.1 Chromium: 112.0.5615.39 (Official Build) nightly (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Linux
  • Verified tokens that only had Transak as provider is not shown in the asset list on Buy screen. More discussion on this here
17773.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove transak assets not supported in US
3 participants