Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] The Brave Rewards option is shown in the 3 dot menu for the brave rewards unavailable countries #28908

Closed
GeetaSarvadnya opened this issue Mar 6, 2023 · 6 comments · Fixed by brave/brave-core#17482

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 6, 2023

Description

Found while testing #25276
The Brave Rewards option is shown in the 3 dot menu for the brave rewards unavailable countries

Steps to reproduce

  1. Follow the steps 1 to 6 from Test Case 1 https://github.com/brave/internal/issues/981#issuecomment-1453252866
  2. In step 6, The Brave Rewards option is shown in the 3 dot menu for the brave rewards unavailable country "Russia"

Actual result

The Brave Rewards option is shown in the 3 dot menu for the brave rewards unavailable countries

image

Expected result

The Brave Rewards option should NOT be shown in the 3 dot menu for the brave rewards unavailable countries

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy
  • Android version: 12

Brave version

1.49.118

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya @Miyayes @brave/qa-team

@GeetaSarvadnya
Copy link
Author

Similar issue on Desktop #27629
cc: @deeppandya

@deeppandya
Copy link

@GeetaSarvadnya we didn't want to hide the rewards button in OFAC case. But if we decide to hide, I have created a PR for the change.

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 6, 2023

@deeppandya We ended up removing it in the desktop case: #27629 So let's remove it on the Android case as well.

@deeppandya
Copy link

@deeppandya We ended up removing it in the desktop case: #27629 So let's remove it on the Android case as well.

@Miyayes in that case, we already have the PR ready for the issue.

@kjozwiak
Copy link
Member

The above requires 1.50.94 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.50.101

Russia

Example Example
Screenshot_20230328-152348_Settings Screenshot_20230328-152303_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants