Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #25010, Reset config should only reset the connection and nothing else #29466

Closed
srirambv opened this issue Apr 3, 2023 · 3 comments · Fixed by brave/brave-core#18000

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 3, 2023

Description

Revert #25010 as per discussion here, Reset config should only reset the connection and nothing else

Steps to reproduce

  1. Purchase VPN
  2. Add apps to split tunnel
  3. Reset config
  4. Only connection should be reset and nothing else should be reset(country/split tunneling)

Actual result

Reset config resets everything

Expected result

Reset config only should reset the connection to the same server

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? NA (VPN not supported)
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya

@deeppandya
Copy link

@srirambv we should also keep the selected server region based on the conversation. i have included the change for split tunnel and server region.

@kjozwiak
Copy link
Member

Waiting on #30552 to be resolved. Once #30552 has been resolved, the above can be verified.

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G on the following build version(s):

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit) 
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using STR in #29466 (comment)

  • Confirmed resetting configuration only resets the VPN profile and not the split tunneling/location settings
Example Example Example Example
screenshot-1685470110420 screenshot-1685470163658 screenshot-1685470169974 screenshot-1685470197445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants