Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Improve UI for private tabs reauth feature #29688

Closed
samartnik opened this issue Apr 13, 2023 · 5 comments · Fixed by brave/brave-core#20703
Closed

[Android] Improve UI for private tabs reauth feature #29688

samartnik opened this issue Apr 13, 2023 · 5 comments · Fixed by brave/brave-core#20703
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@samartnik
Copy link
Contributor

samartnik commented Apr 13, 2023

Description

We want to replace this icon https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/res/drawable/ic_incognito_reauth_promo_icon.xml
Screenshot_20230412-144943

We want to revisit these UI's
Screenshot_20230413-101136

Screenshot_20230413-101153

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@CodeCubeNeo
Copy link

Any updates on this?

@anthonypkeane
Copy link

anthonypkeane commented Oct 12, 2023

@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 12, 2023
@samartnik samartnik self-assigned this Oct 26, 2023
@samartnik
Copy link
Contributor Author

So here we just updated icons and buttons to match Figma to unlock the feature itself. Private tab UI overhaul will be done as a separate task #33949
Screenshot_20231026_143531
Screenshot_20231026_115757

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 28, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

Example Example Example Example
Screenshot_20231228_152043 Screenshot_20231228_152054 Screenshot_20231228_152647 Screenshot_20231228_195830

When a private tab locked/unlocked and no regular tabs are opened

Example Example Example Example Example Example Example
Screenshot_20231228_200919 Screenshot_20231228_200925 Screenshot_20231228_200933 Screenshot_20231228_200942 Screenshot_20231228_200953 Screenshot_20231228_201016 Screenshot_20231228_201023

When a private tab locked/unlocked and a regular tabs is opened

Example Example Example Example Example Example Example Example
Screenshot_20231228_201107 Screenshot_20231228_201112 Screenshot_20231228_201208 Screenshot_20231228_201213 Screenshot_20231228_201229 Screenshot_20231228_201354 Screenshot_20231228_201402 Screenshot_20231228_201427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants