-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Improve UI for private tabs reauth feature #29688
Labels
OS/Android
Fixes related to Android browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA/Yes
release-notes/include
Milestone
Comments
samartnik
added a commit
to brave/brave-core
that referenced
this issue
Apr 17, 2023
Disable until we sort out UI issues brave/brave-browser#29688
This was referenced Apr 17, 2023
Any updates on this? |
anthonypkeane
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Oct 12, 2023
So here we just updated icons and buttons to match Figma to unlock the feature itself. Private tab UI overhaul will be done as a separate task #33949 |
25 tasks
GeetaSarvadnya
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Dec 28, 2023
Verification PASSED on
When a private tab locked/unlocked and no regular tabs are opened
When a private tab locked/unlocked and a regular tabs is opened
|
GeetaSarvadnya
added
QA Pass - Android ARM
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OS/Android
Fixes related to Android browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA/Yes
release-notes/include
Description
We want to replace this icon https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/res/drawable/ic_incognito_reauth_promo_icon.xml
We want to revisit these UI's
Steps to reproduce
Actual result
Expected result
Issue reproduces how often
Version/Channel Information:
Device details
Brave version
Website problems only
Additional information
The text was updated successfully, but these errors were encountered: