Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch viewing duration is resetting to zero when pausing and/or playing #3007

Closed
jasonrsadler opened this issue Jan 17, 2019 · 1 comment · Fixed by brave/brave-core#1397

Comments

@jasonrsadler
Copy link

Description

When viewing twitch videos, pausing and replaying a video will reset a publishers viewing duration count

Steps to Reproduce

  1. Open clean profile Brave and view a Twitch video
  2. Open SQLite database and observe time recorded in activity_info->duration
  3. Pause video briefly and then unpause

Actual result:

In SQLite database, activity_info->duration will have restarted. This will also affect percentages in auto-contribute table.

Expected result:

Viewing duration should be comprehensive during an allocation period and not be reset.

Reproduces how often:

Always

Brave version (brave://version info)

0.61 - Nightly

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    It does not reproduce on current release 58.21. Duration is calculated correctly.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 17, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 19, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 21, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 21, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 21, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 13, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified test plan from Fixes activity duration log brave-core#1397
  • Verified steps from description
  • Verified duration was not reset when pausing or seeking in videos. Verified viewing a couple videos by same publisher added time to same publisher record each time a different video was viewed.

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from test plan from brave/brave-core#1397
Tested on twitch and youtube

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Used test plan from test plan from brave/brave-core#1397
Tested on twitch and youtube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants