Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog after first establishing a monthly tip that indicates amount and date of first tip #3023

Closed
davidtemkin opened this issue Jan 19, 2019 · 6 comments · Fixed by brave/brave-core#1433

Comments

@davidtemkin
Copy link

After a user has set up a monthly tip using the tipping panel, a confirmation dialog should appear in place of the current simple "Thank you" dialog that says thank you, and also indicates the name of the site being tipped, amount of monthly tip, and the date on which the first tip will be sent.

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 20, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 20, 2019
@ryanml
Copy link
Contributor

ryanml commented Jan 20, 2019

Design to be implemented:

image

@NejcZdovc
Copy link
Contributor

note that there should be letter/logo instead of paper plane, like we have it now

@kjozwiak
Copy link
Member

Will this design also change the look of a regular tip that's not set as recurring? Assuming yes. Could we get a design added into the issue with both recurring and none-recurring implementations? Assuming it will look similar to the above but removing the Monthly and Your first monthly tip will be sent on parts for none-recurring tips.

@kjozwiak
Copy link
Member

Will this design also change the look of a regular tip that's not set as recurring? Assuming yes. Could we get a design added into the issue with both recurring and none-recurring implementations? Assuming it will look similar to the above but removing the Monthly and Your first monthly tip will be sent on parts for none-recurring tips.

Closing the loop here, both designs for recurring and none-recurring tips are outlined in brave/brave-core#1433.

@davidtemkin
Copy link
Author

@jenn-rhim see @kjozwiak above

@btlechowski
Copy link

btlechowski commented Feb 26, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1433

Encountered: #3481
Logged #3494

twitch verified
image

twitch unverified
image

youtube verified
image

youtube unverified
image

site verified
image

site unverified
image

Verification passed on

Brave 0.61.40 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants