Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tip info to confirmation dialog #1433

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Adds tip info to confirmation dialog #1433

merged 1 commit into from
Jan 28, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 24, 2019

Fixes: brave/brave-browser#3023

UI implementation: brave/brave-ui#353

Non-Recurring confirmation:
screen shot 2019-01-23 at 11 36 24 pm

Recurring confirmation:
screen shot 2019-01-23 at 11 37 06 pm

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave from a fresh profile, enable Rewards, accept a grant
  2. Make a recurring tip to a site
  3. Confirm that the confirmation overlay displays info per design
  4. Make a non-recurring tip to a site
  5. Confirm that the confirmation overlay displays info per design
  6. Do this a few times staggering different domains and ensure info is accurate

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler
Copy link
Contributor

@ryanml Can you add brave-ui implementation link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation dialog after first establishing a monthly tip that indicates amount and date of first tip
3 participants