Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards onboarding polishes: Remove default focus ring from "Start using Rewards" due to auto-focus #31112

Closed
1 task
Miyayes opened this issue Jun 16, 2023 · 2 comments · Fixed by brave/brave-core#18985
Closed
1 task

Rewards onboarding polishes: Remove default focus ring from "Start using Rewards" due to auto-focus #31112

Miyayes opened this issue Jun 16, 2023 · 2 comments · Fixed by brave/brave-core#18985
Assignees
@mkarolin
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.57.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 16, 2023 •
edited
Loading

Tasks
Beta Give feedback

image

Brave 1.54.65 Chromium: 114.0.5735.133 (Official Build) nightly (x86_64)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS macOS Version 13.4 (Build 22F66)

Put QA/No because this should just be viewed as part of the Rewards onboarding testing, and any version higher than when this fix goes in should be fine.
@Miyayes Miyayes added QA/No release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 16, 2023
@mkarolin mkarolin mentioned this issue Jun 21, 2023
Merged
25 tasks
@Miyayes Miyayes changed the title Rewards onboarding polishes: Start Using Rewards button Rewards onboarding polishes: Start Using Rewards button has focus ring by default Jun 23, 2023
@Miyayes Miyayes changed the title Rewards onboarding polishes: Start Using Rewards button has focus ring by default Rewards onboarding polishes: Remove default focus ring from "Start using Rewards" due to auto-focus Jun 23, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 26, 2023
@brave-builds brave-builds mentioned this issue Jun 26, 2023
Merged
7 tasks
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Jun 29, 2023
@kjozwiak
Copy link
Member

The above requires 1.54.85 or higher for 1.54.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 12, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.57.6 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}
OS | Windows 10 Version 22H2 (Build 19045.3086)

Using the STR/Cases outlined via #31112 (comment), ensured that the focus ring isn't visible when initially opening the rewards panel as per the following:

image

Additional testing on the on the rewards onboarding is covered in #30308 (comment)

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

[Rewards] Removes focus ring from onboarding button. brave/brave-core
5 participants
@kjozwiak @Miyayes @GeetaSarvadnya @mkarolin @brave-builds