Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 115.0.5790.32 to Chromium 115.0.5790.40 #31207

Closed
emerick opened this issue Jun 21, 2023 · 9 comments · Fixed by brave/brave-core#18991
Closed

Upgrade from Chromium 115.0.5790.32 to Chromium 115.0.5790.40 #31207

emerick opened this issue Jun 21, 2023 · 9 comments · Fixed by brave/brave-core#18991

Comments

@emerick
Copy link
Contributor

emerick commented Jun 21, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/115.0.5790.32..115.0.5790.40?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

kjozwiak commented Jun 23, 2023

Quick overview of the work remaining re: affected areas due to C115 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #30200 (comment).

Platforms that still need to check/verify the affected areas due to C115 changes as per #30200 (comment).

  • Android Tablet - Still needs to check affected areas
  • macOS - Still needs to check remaining affected areas

@LaurenWags
Copy link
Member

Per discussion with @emerick this is not included in 1.53.103, will be in a later 1.53.x build. Marking as QA/Blocked for now.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 23, 2023

The above requires 1.53.104 or higher for 1.53.x verification 👍 Removed QA/Blocked as I'll be kicking off new builds in a few minutes so we should have them available in ~3-4hrs.

@stephendonner
Copy link

Verified PASSED using

Brave 1.53.104 Chromium: 115.0.5790.40 (Official Build) (x86_64)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS macOS Version 11.7.8 (Build 20G1351)
Screen Shot 2023-06-23 at 4 32 30 PM

Also verified using

Brave | 1.53.103 Chromium: 115.0.5790.32 (Official Build) (x86_64)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | macOS Version 14.0 (Build 23A5276g)

via #30200 (comment)

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 10 Version 22H2 (Build 19045.3086)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit) 
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
screenshot-1687824176137 screenshot-1687824185099

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit) 
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
screenshot-1687874266037 screenshot-1687875969390

@LaurenWags
Copy link
Member

Verified with

Brave	1.53.107 Chromium: 115.0.5790.40 (Official Build) (64-bit) 
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Linux
Screenshot 2023-06-29 at 10 15 48 AM

@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #31362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment