Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 115.0.5790.40 to Chromium 115.0.5790.56 #31362

Closed
emerick opened this issue Jun 28, 2023 · 6 comments · Fixed by brave/brave-core#19093
Closed

Upgrade from Chromium 115.0.5790.40 to Chromium 115.0.5790.56 #31362

emerick opened this issue Jun 28, 2023 · 6 comments · Fixed by brave/brave-core#19093

Comments

@emerick
Copy link
Contributor

emerick commented Jun 28, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/115.0.5790.40..115.0.5790.56?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.53.108 or higher for 1.53.x verification 👍 @brave/qa-team please keep an eye on side panel as @emerick mentioned that we needed a desktop change due to Chrome adding a feature to disable side panel companion into a different namespace.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 29, 2023

Quick overview of the work remaining re: affected areas due to C115 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #30200 (comment).

Platforms that still need to check/verify the affected areas due to C115 changes as per #30200 (comment).

  • N/A (all platforms completed running through the affected areas)

Only check would be to make sure side panel is working as per #31362 (comment).

@stephendonner
Copy link

Verified PASSED using

Brave 1.54.85 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS macOS Version 14.0 (Build 23A5276g)

Did new & upgrade-scenario checks.

Screenshot 2023-06-30 at 1 56 02 PM

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.53.108 Chromium: 115.0.5790.56 (Official Build) (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Windows 10 Version 22H2 (Build 19045.3086)

image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.53.108 Chromium: 115.0.5790.56 (Official Build) (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Linux

image

@LaurenWags
Copy link
Member

Changed to QA/No and release-notes/exclude as this is superseded by #31502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants