Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow/Block in permission dialog doesn't work sometimes #32258

Closed
goodov opened this issue Aug 15, 2023 · 3 comments · Fixed by brave/brave-core#19694
Closed

Allow/Block in permission dialog doesn't work sometimes #32258

goodov opened this issue Aug 15, 2023 · 3 comments · Fixed by brave/brave-core#19694
Assignees
@goodov
Labels
OS/Desktop privacy/permissions privacy features related to limiting, lifetime or other permissions QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.57.x - Release #4

Comments

@goodov
Copy link
Member

goodov commented Aug 15, 2023 •
edited
Loading

Allow/Block button is ignored when a permission lifetime was changed less than 500ms ago before pressing the button.

aK522emUjQ.mp4
@goodov goodov self-assigned this Aug 15, 2023
@goodov goodov mentioned this issue Aug 15, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 17, 2023
@goodov
Copy link
Member Author

goodov commented Aug 17, 2023 •
edited
Loading

Test case:

  1. Open https://permission.site
  2. Click Location
  3. Select any permission lifetime value (open combobox and select any item)
  4. Click Allow or Block quickly (less than 0.5s should pass between lifetime selection and a button click).
  5. Expect permission bubble has closed

This was referenced Aug 17, 2023
Merged
Merged
@kjozwiak kjozwiak added the privacy/permissions privacy features related to limiting, lifetime or other permissions label Aug 17, 2023
@kjozwiak
Copy link
Member

The above requires 1.57.50 or higher for 1.57.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 22, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.57.52 Chromium: 116.0.5845.96 (Official Build) (64-bit)
-- | --
Revision | 1f876d1266f048189d3cc887cfa5208508ac8194
OS | Windows 11 Version 22H2 (Build 22621.2134)

Reproduced the issue using 1.57.49 Chromium: 116.0.5845.96

https://github.com/brave/brave-browser/assets/98358127/73614f6d-da28-40a0-94fe-9fae71585716

Verified using the testplan from #32258 (comment).

Confirmed permissions bubble is dismissed when clicked Allow or Block quickly

2023-08-22_12h30_25.mp4

@LaurenWags LaurenWags mentioned this issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
OS/Desktop privacy/permissions privacy features related to limiting, lifetime or other permissions QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release #4
Development

Successfully merging a pull request may close this issue.

Fix permission bubble Allow/Block action after lifetime option change. brave/brave-core
4 participants
@kjozwiak @goodov @brave-builds @MadhaviSeelam