Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YT publisher loses an icon on rewards panel after accessed over other url. Observed on Android. #3266

Closed
gdregalo opened this issue Feb 7, 2019 · 1 comment

Comments

@gdregalo
Copy link

gdregalo commented Feb 7, 2019

Here is a situation observed on Android.

A media publisher can be accessed over several URLs, for example:
https://www.youtube.com/channel/UCtsfHRe2WQnkNH5WYJWL-Yw/videos
https://www.youtube.com/user/nickvonpentz/videos

When browsing a page over first url, the BatPublishers::saveVisitInternal through
RewardsServiceImpl::FetchFavIcon fetches an icon and maps it on a custom url like "https://GUID.invalid" in FaviconService internal database Favicons.
When accessing the same publisher over second url, the same situation happens as above, but FaviconService doesn't download the icon because it's already saved and
RewardsServiceImpl::OnSetOnDemandFaviconComplete returns false which echoes in BatPublishers::onFetchFavIcon as Missing or corrupted favicon file for error.
The above clears database field at publisher_info_db.publisher_info.favIcon.

Fixed in: brave/brave-core#1610

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 14, 2019

closing as this was fixed. Dupe of #3324

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Feb 14, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants