-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect verified youtube publisher favicons in auto contribute table #3324
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
Milestone
Comments
LaurenWags
added
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/Yes
QA/Test-Plan-Specified
regression
labels
Feb 12, 2019
Also, here are how some other sites behave. Looks like regular website favicons (verified/not verified) appear fine. Unverified youtube channels display generic youtube favicon as expected. Youtube site and verified yt channel favicons do not display correctly. |
LaurenWags
changed the title
incorrect youtube publisher favicons in auto contribute table
incorrect verified youtube publisher favicons in auto contribute table
Feb 12, 2019
Reproduced on Ubuntu 17.10
|
18 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Feb 14, 2019
This was referenced Feb 14, 2019
This was referenced Feb 15, 2019
Verification passed only for YT publishers on
Verification passed only for YT publishers on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
Description
Incorrect youtube publisher favicons are displayed in auto contribute table.
Steps to Reproduce
Actual result:
Expected result:
Since publisher is verified, I should see their favicon from their channel.
youtube.com should be showing the youtube icon (not empty favicon).
This image is from 0.59.35 (current release version):
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release: no, does not reproduce on 0.59.35
Website problems only:
Additional Information
cc @brave/legacy_qa
The text was updated successfully, but these errors were encountered: