Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect verified youtube publisher favicons in auto contribute table #3324

Closed
LaurenWags opened this issue Feb 12, 2019 · 6 comments · Fixed by brave/brave-core#1649
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 12, 2019

Description

Incorrect youtube publisher favicons are displayed in auto contribute table.

Steps to Reproduce

  1. Install 0.60.26 and launch with clean profile
  2. Enable rewards (I used panel)
  3. Visit a verified youtube publisher (such as https://www.youtube.com/channel/UCqluXkpvWxWBz6sI1JPAsaA)
  4. I stayed on this page for about 8s.
  5. I then clicked on a video.
  6. Once video started I clicked on BAT logo. At this point, I encountered For media publishers, (youtube, twitch), sometimes publisher panel will switch back to site name rather than publisher name #3043 as the panel changed from publisher info (showing generic YT icon) to youtube.com (showing empty favicon)
  7. Go to view brave://rewards.

Actual result:

screen shot 2019-02-12 at 11 42 57 am

screen shot 2019-02-12 at 11 43 39 am

Expected result:

Since publisher is verified, I should see their favicon from their channel.
youtube.com should be showing the youtube icon (not empty favicon).
This image is from 0.59.35 (current release version):
screen shot 2019-02-12 at 11 45 58 am

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
Brave 0.61.20 Chromium: 72.0.3626.81 (Official Build) dev(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Reproducible on current release: no, does not reproduce on 0.59.35

  • Does it reproduce on brave-browser dev/beta builds? yes, dev and beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa

@LaurenWags LaurenWags added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified regression labels Feb 12, 2019
@LaurenWags
Copy link
Member Author

cc @kjozwiak @rebron @NejcZdovc

@LaurenWags
Copy link
Member Author

Also, here are how some other sites behave. Looks like regular website favicons (verified/not verified) appear fine. Unverified youtube channels display generic youtube favicon as expected. Youtube site and verified yt channel favicons do not display correctly.

This is 0.60.26:
screen shot 2019-02-12 at 11 54 10 am

This is from 0.59.35 for comparison:
screen shot 2019-02-12 at 11 54 03 am

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 12, 2019

Reproducible on Windows 10 x64 - 0.60.27

image

@NejcZdovc NejcZdovc self-assigned this Feb 12, 2019
@LaurenWags
Copy link
Member Author

Looks like Verified twitch publishers are showing their favicon and unverified twitch publishers just show standard twitch icon:
screen shot 2019-02-12 at 3 38 46 pm

@LaurenWags LaurenWags changed the title incorrect youtube publisher favicons in auto contribute table incorrect verified youtube publisher favicons in auto contribute table Feb 12, 2019
@btlechowski
Copy link

Reproduced on Ubuntu 17.10

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

@srirambv
Copy link
Contributor

srirambv commented Feb 18, 2019

Verification passed only for YT publishers on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

image
image

Verification passed only for YT publishers on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 10
  • Verified YT publishers favicon is shown on both BR panel and in a-c table
  • Verified Twitch publishers favicon not shown on both BR panel and in a-c table
    image

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X
  • Verified STR from description
  • Verified that non-verified and verified websites show favicon in a-c table
  • Verified that non-verified YT channels show generic YT icon in a-c table
  • Verified that verified YT channels show channel specific favicon in a-c table
  • Verified that non-verified Twitch channels show generic Twitch icon in a-c table
  • Verified that verified Twitch channels show channel specific favicon in a-c table (except neoness007, I can reproduce Searching and viewing verified pub video doesn't show favicon in BR panel/a-c list #3404 fairly reliably with this channel)
    screen shot 2019-02-19 at 5 32 39 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants