"Open in new tab" is shown in the context menu, but corresponding toggle switch is still not added to the Settings -> Appearance

[hffvld]

Description

Open in new tab is shown in the context menu, but the corresponding toggle switch Only open links in current tab group is still not added to the Settings -> Appearance.

Steps to reproduce

1. Launch Brave
2. Open NTP > Top sites
3. Tap and hold on any of them > Confirm that Open in new tab is shown in the context menu
4. Now go to Settings > Appearance > Observe that Only open links in current tab group toggle switch is not shown

Actual result

Open in new tab is shown in the context menu, but the corresponding toggle switch Only open links in current tab group is still not added to the Settings -> Appearance.

1	2

Expected result

Only open links in current tab group toggle switch must be shown in the Settings -> Appearance to match the tablet experience with the phone.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? No
• Can you reproduce this issue with the current Play Store Beta version? No
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Galaxy Tab S8 (Tablet)
• Android version: Android 13

Brave version

Brave build: 1.60.3
Chromium: 117.0.5938.35 (Official Build) canary (64-bit)
Revision: 6f3491e

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[kjozwiak]

The above requires 1.58.122 or higher for 1.58.x verification 👍

[LaurenWags]

@samartnik should this be release-notes/include or release-notes/exclude?

[samartnik]

should this release-notes/include, i updated it

[hffvld]

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.58.122
Chromium: 117.0.5938.62 (Official Build) (64-bit)
Revision: 623437a8c792953b7bc4574f2d9ccdfd59e0ca67

---

STEPS:

1. Launch Brave
2. Three-dot menu > Settings > Appearance > Find Only open links in current tab group > Verify
3. Close the Settings and open NTP > On Top sites panel tap and hold any favicon > Verify
4. Now disable Only open links in current tab group and repeat Step 3 > Verify

ACTUAL RESULTS:

• Verified that Only open links in current tab group toggle switch is shown in the Settings > Appearance
• Verified that Only open links in current tab group toggle switch is ON by default
• Verified that Open in new tab is shown in the context menu when Only open links in current tab group is ON or OFF
• Verified that now enabling or disabling Only open links in current tab group toggle switch is not requiring Brave restart
• Verified above with fresh install and upgrade profile install

---

1	2

Fresh install

timestamp_09-59-16_10-00-22_1.mov

Upgrade install

timestamp_10-03-35_10-04-29.mp4