Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for opening links within Tab Groups #20118

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Sep 11, 2023

Resolves brave/brave-browser#32853
Resolves brave/brave-browser#32854

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 11, 2023
@samartnik samartnik added this to the 1.60.x - Nightly milestone Sep 11, 2023
@samartnik samartnik self-assigned this Sep 11, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit f0b4acc into master Sep 12, 2023
8 checks passed
@samartnik samartnik deleted the android_open_link_fix branch September 12, 2023 00:37
brave-builds added a commit that referenced this pull request Sep 12, 2023
brave-builds added a commit that referenced this pull request Sep 12, 2023
@hffvld
Copy link
Collaborator

hffvld commented Sep 12, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.60.14
Chromium: 117.0.5938.48 (Official Build) canary (64-bit)
Revision: 988f725c9e62f571c6622c233aa00ae129504fd3

Verification for: "Open in new tab" is shown in the context menu, but corresponding toggle switch is still not added to the Settings -> Appearance - PASS

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Appearance > Find Only open links in current tab group > Verify
  3. Close the Settings and open NTP > On Top sites panel tap and hold any favicon > Verify
  4. Now disable Only open links in current tab group and repeat Step 3 > Verify

ACTUAL RESULTS:

  • Verified that Only open links in current tab group toggle switch is shown in the Settings > Appearance
  • Verified that Only open links in current tab group toggle switch is ON by default
  • Verified that Open in new tab is shown in the context menu when Only open links in current tab group is ON or OFF
  • Verified that now enabling or disabling Only open links in current tab group toggle switch is not requiring Brave restart

1 2
1 2
timestamp_12-21-33_12-22-20.mp4
Verification for: "Open in new tab" is not working as expected and instead is opening a new tab in group - PASS

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Appearance > Confirm that Only open links in current tab group is ON
  3. NTP > On Top sites tap and hold on any favicon > Tap Open in new tab in group
  4. Tap Switch tab button > Verify
  5. NTP > On Top sites tap and hold on any favicon > Tap Open in new tab
  6. Tap Switch tab button > Verify
  7. NTP > Open https://foxnews.com or any other supported website > Open any article
  8. Tap on a link in the article > Tap Switch tab button > Verify
  9. Now go to Settings and disable Only open links in current tab group
  10. Repeat Steps 3 - 8

ACTUAL RESULTS:

  • Verified that a new tab is opened in a group when using Open in new tab in group option in the context menu when Only open links in current tab group is ON or OFF
  • Verified that a new tab is opened as a separate tab and not in a group when using Open in new tab option in the context menu when Only open links in current tab group is ON or OFF
  • Verified that links on supported websites are opened in a group when Only open links in current tab group is ON
  • Verified that links on supported websites are opened in a separate tab when Only open links in current tab group is OFF

timestamp_10-59-23_11-00-38_1.mov
timestamp_12-43-13_12-44-39_1.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
3 participants