Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTA button must be disabled/grayed out when Custom filter list URL text field is empty #33178

Closed
hffvld opened this issue Sep 21, 2023 · 1 comment · Fixed by brave/brave-core#20387
Assignees
Labels

Comments

@hffvld
Copy link
Contributor

hffvld commented Sep 21, 2023

Description

The Add CTA button must be disabled/grayed out when the Custom filter list URL text field is empty.

Steps to reproduce

  1. Luanch Brave
  2. Three-dot menu > Settings
  3. Brave Shields & privacy > Content Filtering
  4. Add custom filter list > Observe

Actual result

The Add CTA button is not disabled or grayed out when the Custom filter list URL text field is empty.

1 2
1 2

Expected result

The Add CTA button must be disabled/grayed out when the Custom filter list URL text field is empty.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? YES
  • Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 7 (phone)
  • Android version: Android 14

Brave version

Brave build: 1.59.93
Chromium: 117.0.5938.88 (Official Build) beta (64-bit)
Revision: 77474ed80832bd2c90be4ebf993b6c2a43f662b0

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added OS/Android Fixes related to Android browser functionality bug QA/Yes labels Sep 21, 2023
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 11, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 17, 2023
@hffvld
Copy link
Contributor Author

hffvld commented Nov 17, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B2.230922.013 release-keys]
Brave build: 1.61.77 
Chromium: 119.0.6045.163 (Official Build) beta (64-bit) 

STEPS:

  1. Followed the steps from Add CTA button must be disabled/grayed out when Custom filter list URL text field is empty #33178 (comment)

ACTUAL RESULTS:

  • Verified that the Add CTA button is grayed out/inactive when no input is provided in the text field.
  • Verified that adding custom filter list is working

1 2
1 2
2023-11-17_15-48-42.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants