Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards page element alignment issue when browser window is resized #3323

Closed
srirambv opened this issue Feb 12, 2019 · 4 comments
Closed

Rewards page element alignment issue when browser window is resized #3323

srirambv opened this issue Feb 12, 2019 · 4 comments

Comments

@srirambv
Copy link
Contributor

Description

Rewards page element alignment issue when browser window is resized

Steps to Reproduce

  1. Open rewards page and resize and see the magic else watch the video

Actual result:

https://youtu.be/TKu9cHLY-e0

Expected result:

Not what it looks like in the video

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @ryanml @brave/design

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Feb 12, 2019
@ryanml
Copy link
Contributor

ryanml commented Feb 12, 2019

@jenn-rhim do you think we should do a minimum width (similar to rewards settings) for the welcome page on desktop?

@jenn-rhim
Copy link

Yes. Let's keep it 1024 so it'll work also on tablets.

@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Feb 14, 2019
@kjozwiak
Copy link
Member

Reproduced this on macOS 10.14.2 x64 using the following build:

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

Example of the issue occurring:

screen shot 2019-02-20 at 5 25 04 pm

@NejcZdovc NejcZdovc removed the priority/P4 Planned work. We expect to get to it "soon". label Apr 10, 2020
@NejcZdovc
Copy link
Contributor

not reproduce anymore

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes design A design change, especially one which needs input from the design team release-notes/exclude labels Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants