Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel shows 0% Attention but a-c table has a value for attention % #3329

Closed
LaurenWags opened this issue Feb 12, 2019 · 3 comments
Closed

panel shows 0% Attention but a-c table has a value for attention % #3329

LaurenWags opened this issue Feb 12, 2019 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

Rewards Panel shows Attention as 0% when site does have an attention percentage value.

Does not occur on 0.59.35 (currently released version) or Dev 0.61.20.

Steps to Reproduce

  1. Clean profile.
  2. Launch Brave and enable rewards.
  3. Visit some sites so you have some attention % values in auto contribute table.
  4. Visit a site where you have an attention %.
  5. Click on BAT logo.

Actual result:

Panel shows 0% but ac table shows a value. Reproduces for YT and Twitch sites as well.
screen shot 2019-02-12 at 4 27 43 pm

Expected result:

Panel should show value from a-c table (this is from 0.59.35):
screen shot 2019-02-12 at 4 30 20 pm

screen shot 2019-02-12 at 4 30 41 pm

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Reproducible on current release: no, not on 0.59.35

  • Does it reproduce on brave-browser dev/beta builds? beta yes, dev (0.61.20) no.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa @NejcZdovc

@NejcZdovc
Copy link
Contributor

@LaurenWags this one should be fixed with brave/brave-core#1642

@NejcZdovc
Copy link
Contributor

fixed with brave/brave-core#1642

@btlechowski
Copy link

btlechowski commented Feb 19, 2019

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Verified STR from the description.
image
image

Logged #3409

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

image
image

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants