Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Impact.com's irclickid from query string #33952

Closed
fmarier opened this issue Oct 26, 2023 · 3 comments
Closed

Remove Impact.com's irclickid from query string #33952

fmarier opened this issue Oct 26, 2023 · 3 comments
Assignees
Labels

Comments

@fmarier
Copy link
Member

fmarier commented Oct 26, 2023

Impact.com uses the irclickid query string parameter to track a consumer journey meaning that it is at the granularity of a single person. It does not appear to be linked to someone's identity and instead seems to be randomly generated, but it is meant to be used as a stable identifier to recognize a single user across different pages.

Sample URL:

$ curl --head -L https://effortlessgent.com/spier-and-mackay-donegal-coat/
HTTP/2 302 
date: Thu, 26 Oct 2023 18:03:08 GMT
content-type: text/html; charset=UTF-8
location: https://imp.i317572.net/PykDke

HTTP/2 301 
date: Thu, 26 Oct 2023 18:03:08 GMT
content-length: 0
location: https://www.spierandmackay.com/product/brown-donegal-overcoat--c3282-8011-sboc-fw22?irclickid=QQD2zbykJxyPTmGz47wiYyUCUkFQ2fRt028z140&irgwc=1

HTTP/2 200 
server: nginx
date: Thu, 26 Oct 2023 18:03:09 GMT
content-type: text/html; charset=UTF-8
@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Oct 26, 2023
@fmarier fmarier self-assigned this Oct 26, 2023
@fmarier
Copy link
Member Author

fmarier commented Oct 27, 2023

Other impact.com parameters are removed by the "copy clean link" feature: brave/adblock-lists#1377

@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.29 Chromium: 119.0.6045.105 (Official Build) nightly (x86_64)
-- | --
Revision | 722db0323f23c1aaee8a62326083bced61909279
OS | macOS Version 14.2 (Build 23C5030f)

Steps:

  1. installed 1.62.29
  2. launched Brave
  3. loaded https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes with the Developer Tools' console open

Confirmed entering and trying to load https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes resulted in only https://brave.com/?foo=bar&clean=yes being loaded

Screenshot 2023-11-06 at 3 22 59 PM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 27, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

  • When https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes is loaded in the URL bar only https://brave.com/?foo=bar&clean=yes is loaded in the URL bar

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

3 participants