Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 119.0.6045.66 to Chromium 119.0.6045.105 #34024

Closed
emerick opened this issue Oct 31, 2023 · 5 comments · Fixed by brave/brave-core#20783
Closed

Upgrade from Chromium 119.0.6045.66 to Chromium 119.0.6045.105 #34024

emerick opened this issue Oct 31, 2023 · 5 comments · Fixed by brave/brave-core#20783

Comments

@emerick
Copy link
Contributor

emerick commented Oct 31, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/119.0.6045.66..119.0.6045.105?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2023

Quick overview of the work remaining re: affected areas due to C119 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #33274 (comment):

Platforms that still need to check/verify the affected areas due to C119 changes as per #33274 (comment):

  • macOS - Still requires a pass through the affected areas

  • Linux - Still requires a pass through the affected areas

@stephendonner
Copy link

stephendonner commented Nov 1, 2023

Verification PASSED using

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
-- | --
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 11.7.10 (Build 20G1427)
Screen Shot 2023-11-01 at 9 40 42 PM
Sync - PASSED

I. Browse/manual remove history entries - PASSED

Steps:

deviceA = personal laptop

deviceB = work laptop

deviceC = Android 9

  1. on deviceA, I installed 1.60.110
  2. launched Brave
  3. clicked on the "hamburger" menu
  4. clicked on More Tools -> Sync
  5. clicked on Start a new Sync Chain
  6. clicked on Computer
  7. noted the sync-chain code
  8. clicked OK
  9. clicked on Manage your synced devices
  10. clicked to enable History along with Bookmarks, in Customize sync
  11. confirmed Stephens-MacBook-Pro-2 joined the Device List
  12. launched 1.60.110 on deviceB
  13. opened brave://settings/braveSync
  14. clicked on Start using sync
  15. clicked I have a sync code
  16. entered the sync-chain code from deviceA on deviceB
  17. clicked OK
  18. clicked on History to toggle it to On, along with already-on Bookmarks
  19. returned to deviceA
  20. opened a new window (leaving original Sync one open)
  21. loaded https://search.brave.com/search?q=1000001&source=web
  22. loaded https://search.brave.com/search?q=1000002&source=web in a new tab
  23. loaded https://search.brave.com/search?q=1000003&source=web in a new tab
  24. returned to deviceB
  25. opened a new window (leaving original Sync one open)
  26. loaded https://search.brave.com/search?q=2000001&source=web
  27. loaded https://search.brave.com/search?q=2000002&source=web in a new tab
  28. loaded https://search.brave.com/search?q=2000003&source=web in a new tab
  29. waited a minute or so for good measure
  30. clicked on the "hamburger" menu
  31. clicked on History -> History
  32. clicked on the magnifying-glass (search) icon
  33. typed search.brave.com
  34. confirmed both sets of URLs appeared in history
  35. back on deviceA, removed https://search.brave.com/search?q=2000002&source=web url from history
  36. on deviceB, removed https://search.brave.com/search?q=1000002&source=web url from history;
  37. waited a little (~30s), refreshed brave://history pages. Expected not to have https://search.brave.com/search?q=2000002&source=web and https://search.brave.com/search?q=1000002&source=web on both deviceA and deviceB.
  38. on Android 9 (also 1.60.110), joined deviceC to the sync chain
  39. tapped to also enable the history sync datatype
  40. checked brave://history page on deviceC - expected not to have urls https://search.brave.com/search?q=2000002&source=web and https://search.brave.com/search?q=1000002&source=web

deviceA

example example example example example example
Screenshot 2023-11-01 at 9 24 39 PM Screenshot 2023-11-01 at 6 44 08 PM Screenshot 2023-11-01 at 6 46 57 PM Screenshot 2023-11-01 at 6 47 53 PM Screenshot 2023-11-01 at 6 47 59 PM Screenshot 2023-11-01 at 6 48 02 PM

deviceB

example example example example example example
Screen Shot 2023-11-01 at 6 43 17 PM Screen Shot 2023-11-01 at 6 44 54 PM Screen Shot 2023-11-01 at 6 46 21 PM Screen Shot 2023-11-01 at 6 48 15 PM Screen Shot 2023-11-01 at 6 48 18 PM Screen Shot 2023-11-01 at 6 48 22 PM

deviceC

example example example example example
Screenshot_20231101-185258 Screenshot_20231101-185312 Screenshot_20231101-185320 Screenshot_20231101-185334 Screenshot_20231101-185400

II. Time-based history cleanup - PASSED

You may use what you have left from test (I), or you join two devices to the sync chain, enable history, and do some browsing.

  • open Clear browsing data dialog, brave://settings/clearBrowserData
  • on deviceA choose only Browsing history and Time range Last hour, press Clear data
  • ensured corresponding history entries were deleted on other devices
Default search engine and and Brave Search - PASSED

ES (Spain) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example
Captura de pantalla 2023-11-01 a las 10 25 02 Captura de pantalla 2023-11-01 a las 10 25 33 Captura de pantalla 2023-11-01 a las 10 25 41
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.164
  • ensured that Brave was the default SE selected under brave://settings/search for Normal Windows
  • changed Brave to Google for both window types
  • updated to 1.60.110 and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.48.164 Chromium: 110.0.5481.100 1.60.110 Chromium: 119.0.6045.33
Captura de pantalla 2023-11-01 a las 11 24 05 Captura de pantalla 2023-11-01 a las 11 27 58

DE (German) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for Normal windows and Brave was selected as the default for Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines and Brave was listed first
Example Example Example
Bildschirmfoto 2023-11-01 um 17 22 13 Bildschirmfoto 2023-11-01 um 16 43 13 Bildschirmfoto 2023-11-01 um 16 44 48
Updated Profile (Startpage/DDG - modified SE) - PASSED
  • installed 1.48.x
  • Selected Startpage as the default SE selected under brave://settings/search for Normal Windows
  • Change Brave to DDG as the default SE for Private Windows
  • updated to 1.60.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal Windows = Startpage and Private Windows = DDG
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.60.110 Chromium: 119.0.6045.105
Bildschirmfoto 2023-11-01 um 16 21 26 Bildschirmfoto 2023-11-01 um 16 23 05
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for normal windows
  • changed default SE for Private windows from Brave to Google
  • updated to 1.60.x and ensured that Google is still the default SE in both Normal and Private window SE
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 1.60.110 Chromium: 119.0.6045.105
Bildschirmfoto 2023-11-01 um 16 21 26 Bildschirmfoto 2023-11-01 um 16 23 05
Brave VPN - PASSED

Steps:

  1. installed 1.60.110
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth
  5. entered issue33274@mailinator.com and clicked on Get login link
  6. clicked on the link in the resulting email
  7. clicked on Start free trial for Brave VPN
  8. entered Stripe test credit-card information
  9. checked out
  10. clicked on the VPN button
  11. clicked to Connect
  12. confirmed Allow when prompted to add VPN config

Confirmed I was connected and can change servers, etc.

Example Example Example Example Example Example Example
Screen Shot 2023-11-01 at 9 33 31 AM Screen Shot 2023-11-01 at 9 34 37 AM Screen Shot 2023-11-01 at 9 34 40 AM Screen Shot 2023-11-01 at 9 34 51 AM Screen Shot 2023-11-01 at 9 35 15 AM Screen Shot 2023-11-01 at 9 38 40 AM Screen Shot 2023-11-01 at 9 36 23 AM
brave://settings in general, but also brave://settings/cookies specifically - PASSED
  • Confirmed that brave://settings testing is covered in Settings comparison section

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to global shield settings and change the cookies setting to Block all
  3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero 0
  4. Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
  5. Go to brave://settings/cookies and select Allow all cookies
  6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is some value
  7. Go to global shield settings and ensure that the cookies setting is set to Disabled due to step 5

Case 1:

  1. Clean profile 1.61.50 - CR 119
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block cross site cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained

Case 2:

  1. Continuation of case 1
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained

Case 3:

  1. Continuation of case 2
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block cross site cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained
Vertical tabs - PASSED Screen Shot 2023-11-01 at 8 37 45 AM

Change the default theme and enable vertical tabs:

  • Change the theme via brave://settings/appearance and enable vertical tabs
  • Confirmed that Brave didn't crash
  • Changed various themes and ensured brave didn't crash

General testing on Vertical tabs :

  • Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
  • Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
  • Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
  • Right click on any site added in the vertical tab shows the site context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g News which I have created in my testing) group and ensured that sites got added to the tab group News
  • Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
  • Ensured that the tab Bookmarls all context menu works as expected
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs
Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example Example
Screen Shot 2023-11-01 at 8 45 11 AM Screen Shot 2023-11-01 at 8 46 45 AM Screen Shot 2023-11-01 at 8 48 44 AM Screen Shot 2023-11-01 at 8 48 44 AM Screen Shot 2023-11-01 at 8 51 46 AM Screen Shot 2023-11-01 at 8 53 06 AM Screen Shot 2023-11-01 at 8 53 29 AM Screen Shot 2023-11-01 at 8 53 34 AM Screen Shot 2023-11-01 at 8 53 58 AM Screen Shot 2023-11-01 at 8 54 12 AM Screen Shot 2023-11-01 at 8 54 17 AM Screen Shot 2023-11-01 at 8 54 37 AM Screen Shot 2023-11-01 at 8 54 41 AM Screen Shot 2023-11-01 at 8 55 35 AM Screen Shot 2023-11-01 at 8 55 50 AM Screen Shot 2023-11-01 at 8 55 53 AM Screen Shot 2023-11-01 at 8 56 19 AM Screen Shot 2023-11-01 at 8 56 24 AM Screen Shot 2023-11-01 at 8 56 34 AM Screen Shot 2023-11-01 at 8 57 36 AM Screen Shot 2023-11-01 at 8 57 59 AM Screen Shot 2023-11-01 at 8 58 15 AM

Toggle "Use Vertical tabs" settings ON/OFF

  • Confirmed that Use Vertical tabs toggle ON/OFF works as expected
  • Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
  • Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
  • Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost
Example Example Example
Screen Shot 2023-11-01 at 9 16 05 AM Screen Shot 2023-11-01 at 9 16 24 AM Screen Shot 2023-11-01 at 9 16 40 AM

Show title bar

  • Confirmed that title bar is shown when the Show title bar toggle is turned ON
  • Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF
Example Example
Screen Shot 2023-11-01 at 9 07 18 AM Screen Shot 2023-11-01 at 9 07 22 AM

Float on mouseover and Tab hover mode

  • Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
  • When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
  • Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked
  • Confirmed that Card Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs

tabs

Show tab search button

Encountered #32919

File downloads - PASSED
  • Confirmed download functionality works as expected
  • Confirmed the progress-meter color is "blurple" and matches the download button
  • Confirmed toolbar download button style is as expected
  • Confirmed that a tiny popup is auto opened when download completes
  • Confirmed that Shown in folder opens up the download file path
  • Confirmed that a file can be downloaded via PT and TOR tabs as well
Example Example Example Example Example Example
Screenshot 2023-10-31 at 11 31 29 PM Screenshot 2023-10-31 at 11 21 10 PM Screenshot 2023-10-31 at 11 20 59 PM Screenshot 2023-10-31 at 10 59 57 PM Screenshot 2023-10-31 at 10 56 06 PM Screenshot 2023-10-31 at 10 56 00 PM
Autocomplete - PASSED
  1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
  2. Confirm that autocomplete suggestion checkboxes Top sites, Browsing Hostory, Bookmarks and Leo AI Assistant are enabled by default
  3. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
  4. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
  5. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
  6. Open the buzzfeed.com in any tab
  7. Keep the Top sites still disabled/unchecked
  8. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 6 and autocomplete suggestion is picked up from the Browsing History list
  9. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 7
  10. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
  11. Bookmark the site buzzfeed.com which is already opened in step 6 and close the tab
  12. Keep the brave://settings/appearance setting as it is
  13. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
  14. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
  15. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
  16. Confirm that only Ask Leo option is shown in the autocomplete suggestion
  17. Enter the search string "What is WHO?" and select Ask leo suggetion and hit enter and click on "Accept and begin"
  18. Confirm that Brave AI provides the correct answer for the question "What is WHO?"
  19. Go to brave://settings/appearance setting and disable "Leo AI Assistant" checkbox
  20. Confirm that all the checkboxes are unchecked in this step
  21. Open a new tab and seach with string "Buzz"
  22. Confirmed that no seach suggestions display for the seach string as all the autocomplete suggestion checkboxes are disabled
  23. Enable alll the 4 switches under Show autocomplete suggestions in address bar main switch
  24. Disable the main switch Show autocomplete suggestions in address bar
  25. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF
Example Example Example Example Example Example Example Example Example Example Example Example Example Example
Screen Shot 2023-11-01 at 9 55 10 AM Screen Shot 2023-11-01 at 9 55 19 AM Screen Shot 2023-11-01 at 9 55 34 AM Screen Shot 2023-11-01 at 9 55 41 AM Screen Shot 2023-11-01 at 9 57 02 AM Screen Shot 2023-11-01 at 9 57 35 AM Screen Shot 2023-11-01 at 9 57 44 AM Screen Shot 2023-11-01 at 9 57 58 AM Screen Shot 2023-11-01 at 9 58 09 AM Screen Shot 2023-11-01 at 9 58 33 AM Screen Shot 2023-11-01 at 9 58 47 AM Screen Shot 2023-11-01 at 9 58 53 AM Screen Shot 2023-11-01 at 9 59 41 AM Screen Shot 2023-11-01 at 9 59 47 AM
URL bar functionality, icons, etc. - PASSED
  • Confirmed that info bar color looks as expected in light theme
  • Confirmed that info bar color looks as expected in Dark theme
  • Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
  • Confirmed that the icons in the URL bar works as expected
Light theme Dark theme
Screen Shot 2023-11-01 at 9 24 02 AM Screen Shot 2023-11-01 at 9 24 24 AM
Tab search button - PASSED

Show tab search button

  • Confirmed that Show tab search button settings works as expected with Horitonal tabs orientation
  • Confirmed that able to search particula tabs using search tab option
Example Example
Screen Shot 2023-11-01 at 8 26 02 AM Screen Shot 2023-11-01 at 8 29 52 AM

Settings comparison

Settings comparison - PASSED

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 1, 2023

Verification PASSED on

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit)
-- | --
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | Windows 10 Version 22H2 (Build 19045.3570)

image


Verification PASSED on

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	Linux
Default search engine and and Brave Search_PASSED

IN (India) locale

Clean Profile - PASSED
  • ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was selected as the default via brave://settings/searchEngines
Example Example Example
image image image
Updated Profile (Google/Google - default SE) - PASSED
  • installed 1.48.x
  • ensured that Google was the default SE selected under brave://settings/search for Normal Windows
  • changed Brave to Google for default SE for Private Windows
  • updated to 1.61.x and ensured that Google is still the default SE in both Normal and Private windows SE
    • ensured that it wasn't replaced by Brave
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
1.48.165 Chromium: 110.0.5481.100 1.61.50 Chromium: 119.0.6045.33
image image
Updated Profile (Startpage/DDG - modified SE) - PASSED
  • installed 1.48.x
  • Selected Startpage as the default SE selected under brave://settings/search for Normal Windows
  • Change Brave to DDG as the default SE for Private Windows
  • updated to 1.61.x and ensured that previously selected SE is still the default for both Normal and Private windows
    • Normal Windows = Startpage and Private Windows = DDG
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Normal windows
  • ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
  • ensured that Brave was the first engine via the list under brave://settings/searchEngines
1.48.165 Chromium: 110.0.5481.100 1.61.50 Chromium: 119.0.6045.33
image image
brave://settings in general, but also brave://settings/cookies specifically_PASSED
  • Confirmed that brave://settings testing is covered in Settings comparison section

Update the cookies setting

  1. Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
  2. Go to global shield settings and change the cookies setting to Block all
  3. Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero 0
  4. Open brave://settings/cookies and ensure that the Block cookies settings is enabled due to step 2
  5. Go to brave://settings/cookies and select Allow all cookies
  6. Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is some value
  7. Go to global shield settings and ensure that the cookies setting is set to Disabled due to step 5

Case 1:

  1. Clean profile 1.61.50 - CR 119
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block cross site cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined

Case 2:

  1. Continuation of case 1
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined

Case 3:

  1. Continuation of case 2
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block cross site cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are reatined
Vertical tabs_PASSED

Change the default theme and enable vertical tabs:

  • Change the theme via brave://settings/appearance and enable vertical tabs
  • Confirmed that Brave didn't crash
  • Changed various themes and ensured brave didn't crash

image

General testing on Vertical tabs :

  • Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
  • Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
  • Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
  • Right click on any site added in the vertical tab shows the site context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g News which I have created in my testing) group and ensured that sites got added to the tab group News
  • Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
  • Ensured that the tab Bookmarls all context menu works as expected
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

  • Confirmed that Use Vertical tabs toggle ON/OFF works as expected
  • Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
  • Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
  • Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

Show title bar

  • Confirmed that title bar is shown when the Show title bar toggle is turned ON
  • Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

Float on mouseover and Tab hover mode

  • Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
  • When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
  • Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked
  • Confirmed that Card Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs
    vertical tabs

Show tab search button

  • Confirmed that Show tab search button settings works as expected with Vertical tabs enable
  • Confirmed that able to search particula tabs using search tab option
File downloads_PASSED
  • Confirmed download functionality works as expected
  • Confirmed the progress-meter color is "blurple" and matches the download button
  • Confirmed toolbar download button style is as expected
  • Confirmed that a tiny popup is auto opened when download completes
  • Confirmed that Shown in folder opens up the download file path
  • Confirmed that a file can be downloaded via PT and TOR tabs as well
Example Example Example Example
image image (1) image (2) image (3)
Autocomplete_PASSED
  1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
  2. Confirm that autocomplete suggestion checkboxes Top sites, Browsing Hostory, Bookmarks and Leo AI Assistant are enabled by default
  3. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
  4. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
  5. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
  6. Open the buzzfeed.com in any tab
  7. Keep the Top sites still disabled/unchecked
  8. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 6 and autocomplete suggestion is picked up from the Browsing History list
  9. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 7
  10. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
  11. Bookmark the site buzzfeed.com which is already opened in step 6 and close the tab
  12. Keep the brave://settings/appearance setting as it is
  13. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
  14. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
  15. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
  16. Confirm that only Ask Leo option is shown in the autocomplete suggestion
  17. Enter the search string "What is WHO?" and select Ask leo suggetion and hit enter and click on "Accept and begin"
  18. Confirm that Brave AI provides the correct answer for the question "What is WHO?"
  19. Go to brave://settings/appearance setting and disable "Leo AI Assistant" checkbox
  20. Confirm that all the checkboxes are unchecked in this step
  21. Open a new tab and seach with string "Buzz"
  22. Confirmed that no seach suggestions display for the seach string as all the autocomplete suggestion checkboxes are disabled
  23. Enable alll the 4 switches under Show autocomplete suggestions in address bar main switch
  24. Disable the main switch Show autocomplete suggestions in address bar
  25. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF
URL bar functionality, icons, etc_PASSED
  • Confirmed that info bar color looks as expected in light theme
  • Confirmed that info bar color looks as expected in Dark theme
  • Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
  • Confirmed that the icons in the URL bar works as expected
Light theme Dark theme
image image
Tab search button_PASSED

Show tab search button

  • Confirmed that Show tab search button settings works as expected with Horitonal tabs orientation
  • Confirmed that able to search particula tabs using search tab option
Example Example
image image

Settings comparison

Settings comparison_PASSED

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 1, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (64-bit) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-11-01 at 10 54 12 AM Screenshot 2023-11-01 at 10 54 42 AM

@hffvld
Copy link
Contributor

hffvld commented Nov 1, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.60.110
Chromium: 119.0.6045.105 (Official Build) (64-bit)
Revision: 0bb6e7a81aed340b5a9e8b752c1cf92768257c40


1 2
1 2

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment