-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 119.0.6045.66 to Chromium 119.0.6045.105 #34024
Comments
Quick overview of the work remaining re: affected areas due to Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #33274 (comment):
Platforms that still need to check/verify the affected areas due to
|
Verification
|
example | example | example | example | example | example |
---|---|---|---|---|---|
deviceB
example | example | example | example | example | example |
---|---|---|---|---|---|
deviceC
example | example | example | example | example |
---|---|---|---|---|
II. Time-based history cleanup - PASSED
You may use what you have left from test (I), or you join two devices to the sync chain, enable history, and do some browsing.
- open
Clear browsing data
dialog,brave://settings/clearBrowserData
- on deviceA choose only Browsing history and Time range Last hour, press Clear data
- ensured corresponding history entries were deleted on other devices
Default search engine and and Brave Search - PASSED
ES (Spain) locale
Clean Profile - PASSED
- ensured that
Brave
was selected as the default for both Normal/Private windows viabrave://settings/search
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forPrivate
windows - ensured that
Brave
was selected as the default viabrave://settings/searchEngines
Example |
Example |
Example |
---|---|---|
Updated Profile (Google/Google - default SE) - PASSED
- installed
1.48.164
- ensured that
Brave
was the default SE selected underbrave://settings/search
for Normal Windows - changed
Brave
toGoogle
for both window types - updated to
1.60.110
and ensured thatGoogle
is still the default SE in both Normal and Private windows SE- ensured that it wasn't replaced by
Brave
- ensured that it wasn't replaced by
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forPrivate
windows
1.48.164 Chromium: 110.0.5481.100 |
1.60.110 Chromium: 119.0.6045.33 |
---|---|
DE (German) locale
Clean Profile - PASSED
- ensured that
Brave
was selected as the default for Normal windows andBrave
was selected as the default for Private windows viabrave://settings/search
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forPrivate
windows - ensured that
Brave
was selected as the default viabrave://settings/searchEngines
andBrave
was listed first
Example |
Example |
Example |
---|---|---|
Updated Profile (Startpage/DDG - modified SE) - PASSED
- installed
1.48.x
- Selected
Startpage
as the default SE selected underbrave://settings/search
for Normal Windows - Change
Brave
toDDG
as the default SE for Private Windows - updated to
1.60.x
and ensured that previously selected SE is still the default for both Normal and Private windows- Normal Windows =
Startpage
and Private Windows =DDG
- Normal Windows =
- ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forPrivate
windows - ensured that
Brave
was the first engine via the list underbrave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 |
1.60.110 Chromium: 119.0.6045.105 |
---|---|
Updated Profile (Google/Google - default SE) - PASSED
- installed
1.48.x
- ensured that
Google
was the default SE selected underbrave://settings/search
for normal windows - changed default SE for Private windows from
Brave
toGoogle
- updated to
1.60.x
and ensured thatGoogle
is still the default SE in both Normal and Private window SE - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forNormal
windows - ensured that
Brave
was the first engine via the drop down list underbrave://settings/search
forPrivate
windows - ensured that
Brave
was the first engine via the list underbrave://settings/searchEngines
1.48.164 Chromium: 110.0.5481.100 |
1.60.110 Chromium: 119.0.6045.105 |
---|---|
Brave VPN - PASSED
Steps:
- installed
1.60.110
- launched Brave
- loaded
account.bravesoftware.com
- entered basic-auth
- entered
issue33274@mailinator.com
and clicked onGet login link
- clicked on the link in the resulting email
- clicked on
Start free trial
forBrave VPN
- entered
Stripe
test credit-card information - checked out
- clicked on the
VPN
button - clicked to
Connect
- confirmed
Allow
when prompted to add VPN config
Confirmed I was connected and can change servers, etc.
Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|
brave://settings in general, but also brave://settings/cookies specifically - PASSED
- Confirmed that brave://settings testing is covered in
Settings comparison
section
Update the cookies setting
- Open a site A and and tap on the lock icon and ensured that the cross-site cookies are blocked on the site A
- Go to global shield settings and change the cookies setting to
Block all
- Reload the site A and click on the lock icon and ensure that the cookies blocked and cookies allowed count is zero
0
- Open brave://settings/cookies and ensure that the
Block cookies
settings is enabled due to step 2 - Go to brave://settings/cookies and select
Allow all cookies
- Reload the site A and click on the lock icon and ensured that the cookies are allowed and count value is
some value
- Go to global shield settings and ensure that the cookies setting is set to
Disabled
due to step 5
Case 1:
- Clean profile
1.61.50 - CR 119
- Open a site
- Click on the site shield settings
- Change the trackers and ad blocking settings from
Block cross site cookies
toBlock all cookies
- Restart the browser
- Open the site shield settings, confirmed updated cookies settings are retained
Case 2:
- Continuation of case 1
- Open a site
- Click on the site shield settings
- Change the trackers and ad blocking settings from
Block all cookies
toAllow all cookies
- Restart the browser
- Open the site shield settings, confirmed updated cookies settings are retained
Case 3:
- Continuation of case 2
- Open a site
- Click on the site shield settings
- Change the trackers and ad blocking settings from
Allow all cookies
toBlock cross site cookies
- Restart the browser
- Open the site shield settings, confirmed updated cookies settings are retained
Vertical tabs - PASSED
Change the default theme and enable vertical tabs:
- Change the theme via brave://settings/appearance and enable vertical tabs
- Confirmed that Brave didn't crash
- Changed various themes and ensured brave didn't crash
General testing on Vertical tabs :
- Confirmed that
Use vertical tabs
settings is added inTabs
section under brave://settings/appearance - Confirmed that tabs orientation changed to vertical when user toggle the
Use vertical tabs
settings via brave://settings/appearance - Verified that sites can be added to vertical tab by clicking on the
+ New tab
orCtrl+T
- Right click on any site added in the vertical tab shows the site
context menu
options - Verified that
reading list
andvertical tabs
cab be enabled at the same time - Right click on any site and select
Add tab to reading list
context menu option and ensured site can be added to the reading list - Right click on any site and select
Add a tab to new group
and ensured that the selected site can be added to new tab group - Right click on the sites in vertical tab and select
Add a tab to new group
and then created tab (e.gNews
which I have created in my testing) group and ensured that sites got added to the tab groupNews
- Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
- Right click on any site in vertical tab and select
Move tab to another window
and ensured that tab is opened in an new window - When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
- Right click on any site in vertical tab and select
Reload
context menu option and ensured site gets reloaded/refreshed - Right click on any site in vertical tab and select
Duplicate
context menu option and ensured duplicate tab got added to the tab group - Right click on any site in vertical tab and select
Pin
context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensuredUnpin
option is shown - Ensured that pinned site can be unpinned by clicking on the
Unpin
option - Right click on any YT site in vertical tab and select
mute
context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode. - Ensured that YT videos can be unmuted by clicking on the
Unmute
option - Ensured that
Close
,Close other tabs
,Close tabs to the right
andReopen closed tabs
works as expected - Ensured that the tab
Bookmarls all
context menu works as expected - Ensured that tabs can be drag and drop in an vertical tab
- Ensured that vertical tab cab be collapsed/expanded, when
vertical tabs
is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs
Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Toggle "Use Vertical tabs" settings ON/OFF
- Confirmed that
Use Vertical tabs
toggle ON/OFF works as expected - Confirmed that once the
Use Vertical tabs
toggle is OFF, tabs are shown in horizontal view - Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
- Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost
Example | Example | Example |
---|---|---|
Show title bar
- Confirmed that title bar is shown when the
Show title bar
toggle is turned ON - Confirmed that title bar is NOT shown when the
Show title bar
toggle is turned OFF
Example | Example |
---|---|
Float on mouseover
and Tab hover mode
- Confirmed that
Float on mouseover
settings is enabled by default under brave://settings/appearance - When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
- Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings
Float on mouseover
is unchecked - Confirmed that
Card
Tab hover mode settings works as expected on vertical tabs - Confirmed that
Card with preview
Tab hover mode settings works as expected on vertical tabs - Confirmed that
Tooltip
Tab hover mode settings works as expected on vertical tabs
Show tab search button
Encountered #32919
File downloads - PASSED
- Confirmed download functionality works as expected
- Confirmed the progress-meter color is "blurple" and matches the download button
- Confirmed toolbar download button style is as expected
- Confirmed that a tiny popup is auto opened when download completes
- Confirmed that
Shown in folder
opens up the download file path - Confirmed that a file can be downloaded via PT and TOR tabs as well
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
Autocomplete - PASSED
- Confirm that the
Show autocomplete suggestions in address bar
switch is enabled by default under brave://settings/appearance - Confirm that autocomplete suggestion checkboxes
Top sites
,Browsing Hostory
,Bookmarks
andLeo AI Assistant
are enabled by default - Open a new tab and enter the string
Buzz
in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list - Go to brave://settings/appearance and uncheck/disable the checkbox
Top sites
- Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled - Open the buzzfeed.com in any tab
- Keep the
Top sites
still disabled/unchecked - Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 6 and autocomplete suggestion is picked up from theBrowsing History
list - Go to brave://settings/appearance and uncheck/disable the checkbox
Browsing History
and keep Top sites as it is in step 7 - Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list astop sites
andbrowsing history
toggles are disabled/unchecked - Bookmark the site buzzfeed.com which is already opened in step 6 and close the tab
- Keep the brave://settings/appearance setting as it is
- Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from theBookmarks
list - Go to brave://settings/appearance and uncheck
Bookmarks
(all the 3 settings checkboxes are unchecked in this step) - Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list astop sites
,browsing history
andbookmarks
toggles are disabled/unchecked - Confirm that only
Ask Leo
option is shown in the autocomplete suggestion - Enter the search string "What is WHO?" and select Ask leo suggetion and hit enter and click on "Accept and begin"
- Confirm that Brave AI provides the correct answer for the question "What is WHO?"
- Go to brave://settings/appearance setting and disable "Leo AI Assistant" checkbox
- Confirm that all the checkboxes are unchecked in this step
- Open a new tab and seach with string "Buzz"
- Confirmed that no seach suggestions display for the seach string as all the autocomplete suggestion checkboxes are disabled
- Enable alll the 4 switches under
Show autocomplete suggestions in address bar
main switch - Disable the main switch
Show autocomplete suggestions in address bar
- Open a new tab and enter the string
Buzz
in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list asShow autocomplete suggestions in address bar
main switch is OFF
Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
URL bar functionality, icons, etc. - PASSED
- Confirmed that info bar color looks as expected in light theme
- Confirmed that info bar color looks as expected in Dark theme
- Verified the info bar color in PT/PT with TOR/Guest windows and ensured that the info bar color looks as expected
- Confirmed that the icons in the URL bar works as expected
Light theme | Dark theme |
---|---|
Tab search button - PASSED
Show tab search button
- Confirmed that
Show tab search button
settings works as expected with Horitonal tabs orientation - Confirmed that able to search particula tabs using search tab option
Example | Example |
---|---|
Settings comparison
Settings comparison - PASSED
-
Add/Edit bookmarks settings popup modal is inherited from CR119, this dialog may be reverted via Disable #power-bookmarks-side-panel #33886, please refer slack thread for more info https://bravesoftware.slack.com/archives/CU5UXM3EC/p1698216653317629?thread_ts=1697655851.387759&cid=CU5UXM3EC
-
Updated the brave://settings/appearance section titles for better grouping via Update brave://settings/appearance with section titles and better grouping #33128
Verification PASSED on
Verification PASSED on
Default search engine and and Brave Search_PASSEDIN (India) localeClean Profile - PASSED
Updated Profile (Google/Google - default SE) - PASSED
Updated Profile (Startpage/DDG - modified SE) - PASSED
brave://settings in general, but also brave://settings/cookies specifically_PASSED
Update the cookies setting
Case 1:
Case 2:
Case 3:
Vertical tabs_PASSEDChange the default theme and enable vertical tabs:
General testing on Vertical tabs :
File downloads_PASSED
Autocomplete_PASSED
URL bar functionality, icons, etc_PASSED
Tab search button_PASSED
Settings comparison Settings comparison_PASSED
|
Verified on
|
Verified on
|
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/119.0.6045.66..119.0.6045.105?pretty=fuller&n=10000
QA tests:
Additional checks:
The text was updated successfully, but these errors were encountered: