Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Report, 1.61.104 crashed when closing a tab #34909

Closed
valynor opened this issue Dec 15, 2023 · 4 comments · Fixed by brave/brave-core#21397
Closed

Crash Report, 1.61.104 crashed when closing a tab #34909

valynor opened this issue Dec 15, 2023 · 4 comments · Fixed by brave/brave-core#21397

Comments

@valynor
Copy link

valynor commented Dec 15, 2023

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.

Brave Version: 1.61.104 Chromium: 120.0.6099.115
Operating System: Mac OS X 14.2.0 (arm64)

@simonhong

It seems like the crash on closing a tab (#34785) is not fully fixed in 1.61.104, after ~12 hours being open Brave just crashed to desktop again when I closed a tab.

DO NOT CHANGE BELOW THIS LINE
Crash ID: crash/3f5e0300-100a-300b-0000-000000000000

@simonhong
Copy link
Member

Hmm, it seems crash still happens. Looking.

@kjozwiak
Copy link
Member

The above requires 1.61.108 or higher for 1.61.x verification 👍

@stephendonner
Copy link

stephendonner commented Dec 21, 2023

Verified PASSED using

Brave | 1.61.109 Chromium: 120.0.6099.144 (Official Build) (x86_64)
-- | --
Revision | ea6e204b94e25f08d7a80301c88ba8d2bf96502f
OS | macOS Version 14.3 (Build 23D5033f)

tab-crash-fix

First, reproduced using

Brave | 1.61.104 Chromium: 120.0.6099.115 (Official Build) (x86_64)
-- | --
Revision | 38497f14ca9ff6f1d5b9c1d72f61fec6f0efcf1d
OS | macOS Version 14.3 (Build 23D5033f)

Crash ID: ff020100-a543-390b-0000-000000000000


Screenshot 2023-12-20 at 5 36 49 PM

@LaurenWags
Copy link
Member

Verified with

Brave	1.61.109 Chromium: 120.0.6099.144 (Official Build) (arm64) 
Revision	ea6e204b94e25f08d7a80301c88ba8d2bf96502f
OS	macOS Version 14.2 (Build 23C64)

Reproduced the issue using test plan from brave/brave-core#21397 (comment) and 1.61.104 Chromium: 120.0.6099.115.

Using same steps as test plan, could not reproduce the crash using 1.61.109 Chromium: 120.0.6099.144.

1.61.104 1.61.109
Screenshot 2023-12-21 at 7 50 57 AM Screenshot 2023-12-21 at 7 54 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants