Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave:// pages show up in browsing history #3493

Closed
cndouglas opened this issue Feb 25, 2019 · 5 comments · Fixed by brave/brave-core#1821
Closed

brave:// pages show up in browsing history #3493

cndouglas opened this issue Feb 25, 2019 · 5 comments · Fixed by brave/brave-core#1821

Comments

@cndouglas
Copy link
Contributor

cndouglas commented Feb 25, 2019

Description

Special pages (that begin with brave://, such as brave://history/) show up in the browsing history.

Steps to Reproduce

  1. Go to brave://history/
  2. Look at the latest entry in the browsing history.

Actual result:

The history page is in the browsing history.

Expected result:

The history page should not be in the browsing history.

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.62.8 Chromium: 73.0.3683.39 (Official Build) dev(64-bit)
Revision | cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, 0.62.8 dev.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Not applicable.
  • Is the issue reproducible on the latest version of Chrome? Not sure.

Additional Information

@cndouglas cndouglas changed the title History special page shows up in browsing history brave:// pages shows up in browsing history Feb 25, 2019
@cndouglas cndouglas changed the title brave:// pages shows up in browsing history brave:// pages show up in browsing history Feb 25, 2019
@srirambv
Copy link
Contributor

Reproduced on Linux as well

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 26, 2019
@rebron
Copy link
Collaborator

rebron commented Feb 26, 2019

cc: @simonhong @bridiver can you take a look?

@simonhong
Copy link
Member

simonhong commented Feb 27, 2019

@rebron Yep, I'll take a look after finishing current item(MacOS OS theme controls theme).
also this one(#3506) together. I assume both are similar issue.

@simonhong simonhong self-assigned this Feb 27, 2019
@btlechowski
Copy link

Not reproducible on Release and Beta

Brave 0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows
Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

image

Reproducible on dev

Brave 0.62.8 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 13, 2019

Verification passed on

Brave 0.63.5 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS
  • Verified the STR mentioned in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants