[Android] Disable multi-window support by default

[deeppandya]

Test plan

It shows setting where multiple windows supported

• default setting off
• default setting on if person has multiple windows already and update the app when this feature releases.
• When user tries to feature off when multiple windows already there then it asks the user in the dialog to either merge tabs from multiple windows or close other windows.
• feature off then turning on. In this case, user can create manually new windows from three dot menu settings. And multiple windows can be created when you tap on the some links in the other app and it directly opens in the brave.

Description

• Disable multi window support by default
• Provide an option for user to enable multi-window support

For more context follow : https://bravesoftware.slack.com/archives/C03MMJ4CHEZ/p1704168952026949

[timchilds]

@deeppandya re: option for user to enable multi-window support:

• Toggle available under Display -> Appearance
• Title: Enable Windows
• Sub-title: Open up to 5 windows at a time and move tabs from one window to another

@deeppandya is it possible to show the setting for tablets only? (since the feature only works on tablets). If not, I'll change the copy a little.

[hffvld]

Hi @timchilds @deeppandya
Multi-window was always available on the phones as well. However, it's not so straightforward as on the tablet.

Tablet: Launch Brave > Three-dot menu > New window
Phone: Launch Brave > Open NTP > Tap and hold any favorite icon > In the context menu choose Open in other window > Three-dot menu > Now you can see Move to other window and Manage windows

1	2	3	4

The issue I created for the multi-window #33475

[hffvld]

@deeppandya Looks like the new change completely removed this feature from the phones. Should we keep it on the phones or not?

[deeppandya]

@deeppandya Looks like the new change completely removed this feature from the phones. Should we keep it on the phones or not?

For new users, by default it would be disabled. And if the user wants, they can enable it from settings

[deeppandya]

Hi @timchilds @deeppandya
Multi-window was always available on the phones as well. However, it's not so straightforward as on the tablet.

Tablet: Launch Brave > Three-dot menu > New window
Phone: Launch Brave > Open NTP > Tap and hold any favorite icon > In the context menu choose Open in other window > Three-dot menu > Now you can see Move to other window and Manage windows

1	2	3	4

The issue I created for the multi-window #33475

Regarding this, I think we decided to wait on upstream to change the cancel button position.

[tapanmodh]

@deeppandya Looks like the new change completely removed this feature from the phones. Should we keep it on the phones or not?

For new users, by default it would be disabled. And if the user wants, they can enable it from settings

This feature will not visible in the settings in the phone as there is no option to create new window from menu apart from NTP -> Tap and hold any favorite icon -> Open in other window. Do we want to visible in the settings for this case?

[kjozwiak]

The above requires 1.66.105 or higher for 1.66.x verification 👍

[Uni-verse]

Verified on Samsung Galaxy Tab S7 & Samsung Galaxy S21 using version:

Brave	1.66.105 Chromium: 125.0.6422.41 (Official Build) (64-bit) 
Revision	ba88d7bb175a55287d14014823d5da31fe9c8a47
OS	Android 13; Build/TP1A.220624.014; 33; REL

• Verified the following scenarios on Phone and Tablet mentioned in [Android] Disable multi-window support by default  #35106 (comment) via Show multiple windows toggle in settings for Phone #38203 (comment) & Multiple windows not able to close or merge from settings #38170 (comment)
• default setting off
• default setting on if person has multiple windows already and update the app when this feature releases.
• When user tries to feature off when multiple windows already there then it asks the user in the dialog to either merge tabs from multiple windows or close other windows.
• feature off then turning on. In this case, user can create manually new windows from three dot menu settings. And multiple windows can be created when you tap on the some links in the other app and it directly opens in the brave.