Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PnaCl component missing in official Brave build #3519

Closed
CamelCaseName opened this issue Feb 27, 2019 · 5 comments
Closed

PnaCl component missing in official Brave build #3519

CamelCaseName opened this issue Feb 27, 2019 · 5 comments
Labels
closed/wontfix webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@CamelCaseName
Copy link

Description

The official Brave build misses the Portable Native Client (PNaCl), which, for example, is used by the google earth studio.

Steps to Reproduce

  1. Open Brave
  2. Go to Earth Studio

Actual result:

error

Expected result:

download

Reproduces how often:

Every time

Brave version (brave://version info)

0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)

Revision | fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS | Windows

Website problems only:

It doesn't reproduce with Chrome., and i didn't find any info on the internet on how to install nacl on brave.

@bsclifton
Copy link
Member

We turn this off intentionally:

enable_nacl: false,

Is this something we want to enable?
cc: @bbondy @bridiver @diracdeltas

@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Feb 27, 2019
@diracdeltas
Copy link
Member

according to https://developer.chrome.com/native-client/nacl-and-pnacl, nacl and pnacl are being deprecated

i think we initially turned it off to reduce the security surface area of Brave

@diracdeltas
Copy link
Member

Given the momentum of cross-browser WebAssembly support, we plan to focus our native code efforts on WebAssembly going forward and plan to remove support for PNaCl in Q2 2019 (except for Chrome Apps). We believe that the vibrant ecosystem around WebAssembly makes it a better fit for new and existing high-performance web apps and that usage of PNaCl is sufficiently low to warrant deprecation.

from https://developer.chrome.com/native-client/migration

since Q2 2019 starts soon, i'm inclined to mark this wontfix

@bsclifton
Copy link
Member

@diracdeltas good call 😄

As we don't have any dev resources allocated to look at this (not high demand and Q2 is around the corner), I'll go ahead and close this out 👍

@bbondy
Copy link
Member

bbondy commented Feb 28, 2019

Agreed on this being wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

4 participants