Local files should not be shown with "insecure" icon in the UI

[ZelnickB]

When you open a local file (e.g., a PDF) with Brave (I have tested it with Version 1.61.116 Chromium: 120.0.6099.217 (Official Build) (arm64) on MacOS Apple Silicon), the "insecure" icon used for HTTP sites (insecure origins) is displayed in the address bar:

Local files are not "insecure" like an HTTP site, so perhaps Brave should use an icon like that used in Google Chrome (with an "info" or similar icon appearing next to the "File" label).

[ZelnickB]

Somewhat related to #33755.

[diracdeltas]

cc @rebron @petemill @bradleyrichter does anyone know if this was an intentional design change on our part from Chrome?

[simonhong]

When I load http site different icon is used (rounded triangle)

and circle icon for file scheme.

Is there another way to see circle icon for http site?

[diracdeltas]

@simonhong that's a good point. I think the issue is the exclamation point (!) is associated with insecure sites even though it's not exactly the same UI as insecure. if it was the info icon (i) instead it'd be fine.

[bradleyrichter]

@simonhong swapping over to the info icon would work here

[simonhong]

I found that we have another info icon with i from our icon set (https://www.figma.com/file/g8Z0q6TMPYDq6zXh9Y7LWD/%F0%9F%8C%8E-Universal?type=design&node-id=1419-13501&mode=design&t=Ae5NaXQUaIR2C1LK-0)

Maybe it's good to use here?

[diracdeltas]

lgtm

[aguscruiz]

@simonhong let's used the filled variant there, since the ⚠️ icon is also filled. 👌

[kjozwiak]

The above requires 1.62.155 or higher for 1.62.x verification 👍

[LaurenWags]

Verified with

Brave | 1.62.155 Chromium: 121.0.6167.85 (Official Build) (x86_64)
-- | --
Revision | 91c989228daf153ef41bd965f268fabc7b9dbbf0
OS | macOS Version 13.6.4 (Build 22G513)

Reproduced the issue using 1.62.153 Chromium: 121.0.6167.85.

Using 1.62.155 Chromium: 121.0.6167.85 confirmed that the location bar/omnibox was displaying i rather than ! when opening local files.
Confirmed for both dark and light themes.

1.62.153	1.62.155 (dark)	1.62.155 (light)