Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement Soprano external account option #35334

Closed
Miyayes opened this issue Jan 16, 2024 · 3 comments · Fixed by brave/brave-core#21857
Closed

[Android] Implement Soprano external account option #35334

Miyayes opened this issue Jan 16, 2024 · 3 comments · Fixed by brave/brave-core#21857
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 16, 2024 •
edited
Loading

Description

https://github.com/brave/internal/issues/1105

Update: This does not contain the invitation UI/UX. That is covered in #36549.
@Miyayes Miyayes added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jan 16, 2024
@deeppandya deeppandya mentioned this issue Feb 1, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 7, 2024
@deeppandya deeppandya mentioned this issue Feb 8, 2024
Closed
7 tasks
This was referenced Feb 28, 2024
Closed
Merged
@deeppandya deeppandya mentioned this issue Feb 29, 2024
Merged
7 tasks
@Miyayes Miyayes mentioned this issue Mar 5, 2024
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 5, 2024 •
edited
Loading

@Uni-verse @hffvld QA will need to test #36433 to ensure correct URL for explorer is used for 1.64.x Android release.

@Uni-verse Uni-verse mentioned this issue Mar 5, 2024
Closed
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 12, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 12, 2024 •
edited
Loading

Verified on Android with:

Brave	1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
Revision	f7c8f13563bfe1063db456650cb43207e1c960c0
OS	Android 12; Build/SP1A.210812.016.C1; 31; REL

Verification notes can be found under https://github.com/brave/internal/issues/1105#issuecomment-1992119194

Encountered the following issues while testing:

Per #35334 (comment), also verified that the "Go to my Solana account" link from panel and brave://rewards page directs to https://explorer.solana.com/address/......./tokens as expected:

Panel brave://rewards page
Screenshot_20240314-092449 Screenshot_20240314-092552
Screenshot_20240314-092503 Screenshot_20240314-092557
Screenshot_20240314-092525 Screenshot_20240314-092604

This was referenced Mar 13, 2024
Closed
Closed
@LaurenWags LaurenWags added QA/Test-All-Platforms QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 14, 2024
@srirambv
Copy link
Contributor

Verification passed on Lenovo Tab with Android 13 running 1.63.107 x64 build.

  • Verification notes can be found here

@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Solana payouts android brave/brave-core
6 participants
@deeppandya @Miyayes @srirambv @Uni-verse @LaurenWags @brave-builds