Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Omaha v1.3.361.149 for new users #35684

Closed
mherrmann opened this issue Jan 30, 2024 · 4 comments · Fixed by brave/brave-core#21814
Closed

Install Omaha v1.3.361.149 for new users #35684

mherrmann opened this issue Jan 30, 2024 · 4 comments · Fixed by brave/brave-core#21814
Assignees
@mherrmann
Labels
feature/updater installer/omaha Issues for windows omaha installer OS/Desktop OS/Windows QA Pass-Win64 QA Pass-Win86 QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@mherrmann
Copy link

mherrmann commented Jan 30, 2024 •
edited
Loading

Our automatic update mechanism on Windows is implemented via a fork of Google's "Omaha" technology. Google have released several new versions. We want to pull in those improvements by releasing a new version of our copy of Omaha with the new changes.

Omaha runs as a separate application on users' systems. It gets installed when the user first installs Brave. The goal of this issue is to make Brave's Windows installers install our new version 1.3.361.149 of Omaha. There are no functional changes in the new version of the updater.

After the implementation for this issue has hit Release, we should also install the the new Omaha version for existing users. This is captured by #35685.
@mherrmann mherrmann self-assigned this Jan 30, 2024
@mherrmann mherrmann added OS/Windows feature/updater installer/omaha Issues for windows omaha installer labels Jan 30, 2024
This was referenced Jan 30, 2024
Closed
Merged
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 31, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 3, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | f7c8f13563bfe1063db456650cb43207e1c960c0
OS | Windows 11 Version 23H2 (Build 22631.3155)

Windows 11x64

Test Case 1: Verify Brave's various Windows installers on a new install.

Case 1: Verify correct Omaha updater version installed with `Standalone` installer - `PASSED`
  1. Uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded and installed BraveBrowserStandaloneBetaSetup.exe installer for 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetup.exe
  3. confirmed 1.64.97 installed with admin privileges successfully
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  5. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Uninstall the 1.64.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  7. Install the 1.64.x again and confirmed that the brave installed successfully
  8. open brave://settings/help and wait for the update and click on the Relaunch
  9. confirmed that brave is upgraded to latest public version
step 3 step 4 step 5 step 7 step 8 step 9
image image image image image image
Case 2: Verify correct Omaha updater version installed with `StandaloneSilent` installer - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded and installed BraveBrowserStandaloneSilentBetaSetup.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneSilentBetaSetup.exe)
  3. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  4. confirmed 1.64.97 installed successfully (UAC modal is not shown)
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in AppData\Local\BraveSoftware\Update
  7. confirmed correct version details are shown brave://settings/help
step 4 step 5 step 6 step 7
image image image image
Case 3: Verify correct Omaha updater version installed with `Stub installer` - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed BraveBrowserBetaSetup.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserBetaSetup.exe)
  4. confirmed 1.64.97 installed successfully with admin privileges
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  7. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched from the Omaha server as expected
step 4 step 5 step 6
image image image
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
  1. Uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded BraveBrowserStandaloneBetaSetup.exe installer for 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetup.exe
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.97 installed without admin privileges successfully
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  7. open brave://settings/help and wait for the update and click on the Relaunch
  8. confirmed that brave is upgraded to latest public version
step 3 step 4 step 5 step 7 step 8 step 9
image image image image image image
Case 5: Verify stub installer can be installed without admin rights - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded BraveBrowserBetaSetup.exe installer 1.64.95 - (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe)
  4. declined the Admin rights in UAC while installing Brave
  5. confirmed 1.64.97 installed successfully with admin privileges
  6. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public release beta version is fetched from the Omaha server as expected
step 4 step 5 step 6
image image image

Test Case 2: Verify Brave's various Windows installers for on demand update

Verify correct Omaha updater version installed with `Standalone` installer for on demand update - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneBetaSetup.exe installer 1.64.90 - https://github.com/brave/brave-browser/releases/download/v1.64.90/BraveBrowserStandaloneBetaSetup.exe
  4. confirmed 1.64.90 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown C:\Program Files (x86)\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown C:\Program Files (x86)\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for on demand update - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneSilentBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup.exe
  4. confirmed 1.64.95 installed
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for on demand update - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe
  4. confirmed stub installer for 1.64.97 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
example example example example
image image image image

Testcase : Background updates via the Windows Task Scheduler.

Verify correct Omaha updater version installed with `Standalone` installer for Background updates - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an offline (“standalone”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.95.
  6. Check that the registry value
    BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 10. and 11. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.97
step 5 step 6 step 7 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
image image image image image image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an silent (“StandaloneSilent”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.95
  6. Check that the registry value
    BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.145.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “TaskUser” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 11. and 12. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.102
step 5 step 6 step 8 step 9 step 12 step 13 step 14 step 15 step 17 step 18 step 20 step 21
image image image image image image image image image image image image
Verify correct Omaha updater version installed with `Stub installer` installer for Background updates - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download “Stub installer” installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed latest Brave-Beta successfully 1.64.102
  6. Check that the registry value
    BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  16. Open Brave.
  17. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  18. Confirmed Brave updated to latest public version 1.64.102
step 5 step 8 step 9 step 12 step 13 step 14 step 17-18
image image image image image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 7, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 8, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (arm64)
-- | --
Revision | f7c8f13563bfe1063db456650cb43207e1c960c0
OS | Windows 11 Version 23H2 (Build 22631.3235)

Windows ARM64 Verifications

Test Case 1: Verify Brave's various Windows installers on a new install.

Case 1: Verify correct Omaha updater version installed with `Standalone` installer`- PASSED
  1. Uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded and installed BraveBrowserStandaloneBetaSetupArm64.exe installer for 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetupArm64.exe
  3. confirmed 1.64.97 installed with admin privileges successfully
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  5. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Uninstall the 1.64.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  7. Install the 1.64.95 again and confirmed that the brave installed successfully
  8. open brave://settings/help and wait for the update and click on the Relaunch
  9. confirmed that brave is upgraded to latest public version 1.64.95
step 3 step 4 step 5 step 7 step 8 step 9
image image image image image image
Case 2: Verify correct Omaha updater version installed with `StandaloneSilent` installer - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded and installed BraveBrowserStandaloneSilentBetaSetupArm64.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetupArm64.exe)
  3. confirmed 1.64.97 installed successfully (UAC modal is not shown)
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  5. confirmed new Omaha updater version 1.3.361.149 is shown in %LocalAppData%\BraveSoftware\Update
  6. confirmed correct version details are shown brave://settings/help
step 3 step 4 step 5 step 6
image image image image
Case 3: Verify correct Omaha updater version installed with `Stub installer` - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed BraveBrowserBetaSetup.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserBetaSetup.exe)
  4. confirmed latest Brave installed successfully with admin privileges
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  7. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version 1.64.102 is fetched from the Omaha server as expected
step 4 step 5 step 6
image image image
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
  1. Uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. downloaded BraveBrowserStandaloneBetaSetupArm64.exe installer for 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetupArm64.exe
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.97 installed without admin privileges successfully
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  7. open brave://settings/help and wait for the update and click on the Relaunch
  8. confirmed that brave is upgraded to latest public version
step 3 step 4 step 5 step 7 step 9
image image image image image
Case 5: Verify stub installer can be installed without admin rights - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded BraveBrowserBetaSetup.exe installer 1.64.95 - (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe)
  4. declined the Admin rights in UAC while installing Brave
  5. confirmed Brave installed successfully without admin privileges
  6. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public release beta version 1.64.102 is fetched from the Omaha server as expected
step 4 step 5 step 6 step 7
image image image image

Test Case 2: Verify Brave's various Windows installers for on demand update

Verify correct Omaha updater version installed with `Standalone` installer for on demand update - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneBetaSetup.exe installer 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetupArm64.exe
  4. confirmed 1.64.97 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown C:\Program Files (x86)\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.102
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown C:\Program Files (x86)\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for on demand update - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneSilentBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup.exe
  4. confirmed 1.64.95 installed
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
    - Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  6. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.102
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `Stub installer` installer for on demand update - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe
  4. confirmed stub installer for 1.64.102 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 4 step 5 step 5 step 8
image image image image

Testcase 3: Background updates via the Windows Task Scheduler - PASSED

Verify correct Omaha updater version installed with `Standalone` installer for Background updates - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an offline (“standalone”) installer for previous non-public version of Brave Beta 1.64.97 (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.97
  6. Check that the registry value
    • BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 10. and 11. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.102
step 5 step 6 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
image image image image image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an silent (“StandaloneSilent”) installer for previous non-public version of Brave Beta 1.64.97 (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneSilentBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.97
  6. Check that the registry value
    - Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “TaskUser” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 11. and 12. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.102
step 5 step 6 step 9 step 12 step 13 step 14 step 15 step 16 step 17 step 18 step 20 step 21
image image image image image image image image image image image image
Verify correct Omaha updater version installed with `Stub installer` for Background updates -PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an silent (“StandaloneSilent”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed latest Brave-Beta successfully 1.64.102
  6. Check that the registry value
    • BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 6. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  16. Open Brave.
  17. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  18. Confirmed Brave updated to latest public version 1.64.102
step 5 step 6 step 8 step 9 step 12 step 13 step 14 step 17-18
image image image image image image image image

@LaurenWags
Copy link
Member

LaurenWags commented Mar 8, 2024 •
edited
Loading

Verified using

Brave	1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (32-bit) 
Revision	f7c8f13563bfe1063db456650cb43207e1c960c0
OS	Windows 10 Version 22H2 (Build 19045.3803)

Windows 10 x86

Test Case 1: Verify Brave's various Windows installers on a new install.

Case 1: Verify correct Omaha updater version installed with `Standalone` (32 bit) installer - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed BraveBrowserStandaloneBetaSetup32.exe installer for 1.64.97 - https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneBetaSetup32.exe
  3. confirmed 1.64.97 installed with admin privileges successfully
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update
  5. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files\BraveSoftware\Update
step 3 step 4 step 5
Screenshot 2024-03-08 at 3 35 42 PM Screenshot 2024-03-08 at 3 36 30 PM Screenshot 2024-03-08 at 3 37 11 PM
Case 2: Verify correct Omaha updater version installed with `StandaloneSilent32` installer - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed BraveBrowserStandaloneSilentBetaSetup32.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserStandaloneSilentBetaSetup32.exe)
  3. confirmed 1.64.97 installed successfully (UAC modal is not shown)
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in AppData\Local\BraveSoftware\Update
  2. confirmed correct version details are shown brave://settings/help
step 4 step 5 step 6
Screenshot 2024-03-08 at 3 53 50 PM Screenshot 2024-03-08 at 3 54 47 PM Screenshot 2024-03-08 at 3 55 11 PM
Case 3: Verify correct Omaha updater version installed with `Stub installer` - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed BraveBrowserBetaSetup.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserBetaSetup.exe)
  3. confirmed 1.64.97 installed successfully with admin privileges
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched from the Omaha server as expected
step 4 step 5 step 6
Screenshot 2024-03-08 at 4 03 47 PM Screenshot 2024-03-08 at 4 05 02 PM Screenshot 2024-03-08 at 4 05 20 PM
Case 4: Verify standalone (32 bit) installer can be installed without admin rights and updater works - PASSED
  1. Used a fresh VM (Brave never installed)
  2. downloaded BraveBrowserStandaloneBetaSetup.exe installer for 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup32.exe
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.95 installed with admin privileges successfully
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files\BraveSoftware\Update
  7. Uninstall the 1.64.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  8. Install the 1.64.x again and confirmed that the brave installed successfully
  9. open brave://settings/help and wait for the update and click on the Relaunch
  10. confirmed that brave is upgraded to latest public version
step 3 step 4 step 5 step 6 step 9 step 10
Screenshot 2024-03-08 at 4 59 44 PM Screenshot 2024-03-08 at 4 57 15 PM Screenshot 2024-03-08 at 4 56 50 PM Screenshot 2024-03-08 at 4 58 01 PM Screenshot 2024-03-08 at 5 01 16 PM Screenshot 2024-03-08 at 5 01 29 PM
Case 5: Verify stub installer can be installed without admin rights - PASSED
  1. Used a fresh VM (Brave never installed)
  2. downloaded BraveBrowserBetaSetup.exe installer 1.64.97 - (https://github.com/brave/brave-browser/releases/download/v1.64.97/BraveBrowserBetaSetup.exe)
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.97 installed successfully without admin privileges
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in %LOCALAPPDATA%\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched from the Omaha server as expected
step 3 step 4 step 5 step 6
3 4 5 6

Test Case 2: Verify Brave's various Windows installers for on demand update

Verify correct Omaha updater version installed with `Standalone` (32 bit) installer for on demand update - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed previous public beta version BraveBrowserStandaloneBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup32.exe
  3. confirmed 1.64.95 installed successfully with admin privileges
  4. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  5. verified Omaha updater version 1.3.361.149 is shown C:\Program Files\BraveSoftware\Update
  6. go to brave://settings/help and wait for update and click on Relaunch
  7. confirmed brave is updated to the latest public beta version 1.64.97
  8. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  9. confirmed Omaha updater version 1.3.361.149 is still shown C:\Program Files \BraveSoftware\Update
step 3 step 4 step 5 step 6 step 7 step 8 step 9
3 4 5 6 7 8 9
Verify correct Omaha updater version installed with `StandaloneSilent` (32 bit) installer for on demand update - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed previous public beta version BraveBrowserStandaloneSilentBetaSetup32.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup32.exe
  3. confirmed 1.64.95 installed
  4. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  5. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  6. go to brave://settings/help and wait for update and click on Relaunch
  7. confirmed brave is updated to the latest public beta version 1.64.97
  8. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  9. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 3 step 4 step 5 step 6 step 7 step 8 step 9
3 4 5 6 7 8 9

Testcase : Background updates via the Windows Task Scheduler.

Verify correct Omaha updater version installed with `Standalone` (32 bit) installer for Background updates - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware (if they existed, which they don't in this case)
  3. Download an offline (“standalone”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup32.exe). Note, 32 bit is only built for public versions, so had to use 1.64.95 for this check as previous versions either did not exist, or ran into a different error.
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.95.
  6. Check that the registry value
    BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 7. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 11-12. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.97
step 5 step 6 step 7 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
5 6 7 8 9 13 14 15 17 18 20 21
Verify correct Omaha updater version installed with `StandaloneSilent` (32 bit) installer for Background updates - `PASSED`
  1. Used a fresh VM (Brave never installed)
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware (if they existed, which they don't in this case)
  3. Download an offline (“standalone silent”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup32.exe). Note, 32 bit is only built for public versions, so had to use 1.64.95 for this check as previous versions either did not exist, or ran into a different error.
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.95.
  6. Check that the registry value
    BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 7. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 11-12. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.97
step 5 step 6 step 7 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
5 6 7 8 9 13 14 15 17 18 20 21

@stephendonner
Copy link

stephendonner commented Mar 8, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.64.98 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | a262f3c44a8960fee49fbf0bd6f5740634f32be7
OS | Windows 10 Version 22H2 (Build 19045.4123)

Windows 10 -x64 - PASSED

Testcase 1: Verify Brave's various Windows installers on a new install - PASSED

Case 1: Verify correct Omaha updater version installed with `Standalone` installer - PASSED
  1. removed previous Brave installation
  2. downloaded and installed BraveBrowserStandaloneBetaSetup.exe installer for 1.64.98 - https://github.com/brave/brave-browser/releases/download/v1.64.98/BraveBrowserStandaloneBetaSetup.exe
  3. confirmed 1.64.98 installed with admin privileges successfully
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  5. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files(x86)\BraveSoftware\Update
step 3 step 4 step 5
image image image
Case 2: Verify correct Omaha updater version installed with `StandaloneSilent` installer - PASSED
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed BraveBrowserStandaloneSilentBetaSetup.exe installer 1.64.98 - (https://github.com/brave/brave-browser/releases/download/v1.64.98/BraveBrowserStandaloneSilentBetaSetup.exe)
  3. confirmed 1.64.98 installed successfully (UAC modal is not shown)
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  2. confirmed correct version details are shown brave://settings/help
step 4 step 5 step 6
image image image
Case 3: Verify correct Omaha updater version installed with `Stub installer` - PASSED
  1. Used a fresh VM (Brave never installed)
  2. downloaded and installed BraveBrowserBetaSetup.exe installer 1.64.98 - (https://github.com/brave/brave-browser/releases/download/v1.64.98/BraveBrowserBetaSetup.exe)
  3. confirmed 1.64.98 installed successfully with admin privileges
  4. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched from the Omaha server as expected
step 4 step 5 step 6
image image image
Case 4: Verify standalone installer can be installed without admin rights and updater works - PASSED
  1. used a fresh VM (Brave never installed)
  2. downloaded BraveBrowserStandaloneBetaSetup.exe installer for 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup.exe
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.95 installed with admin privileges successfully
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
    • HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  6. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Program Files (x86)\BraveSoftware\Update`
  7. uninstalled 1.64.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  8. reinstalled 1.64.x and confirmed that Brave installed successfully
  9. opened brave://settings/help, waited for the update, and clicked on the Relaunch button
  10. confirmed that Brave is upgraded to latest public version
step 3 step 4 step 5 step 6 step 9 step 10
image image image image image image
Case 5: Verify stub installer can be installed without admin rights - PASSED
  1. Used a fresh VM (Brave never installed)
  2. downloaded BraveBrowserBetaSetup.exe installer 1.64.98 - (https://github.com/brave/brave-browser/releases/download/v1.64.98/BraveBrowserBetaSetup.exe)
  3. declined the Admin rights in UAC while installing Brave
  4. confirmed 1.64.97 installed successfully without admin privileges
  5. confirmed that the new Omaha updater 1.3.361.149 is shown in the registry path as below as expected
  • HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  1. confirmed new Omaha updater version 1.3.361.149 is shown in C:\Users\steph\AppData\Local\BraveSoftware\Update
  2. confirmed stub installer BraveBrowserBetaSetup.exe installed Brave successfully and latest public released beta version is fetched from the Omaha server as expected
step 3 step 4 step 5 step 6 step 7
image image image image image

Testcase 2: Verify Brave's various Windows installers for on-demand update - PASSED

Verify correct Omaha updater version installed with `Standalone` installer for on demand update - PASSED
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneBetaSetup.exe installer 1.64.90 - https://github.com/brave/brave-browser/releases/download/v1.64.90/BraveBrowserStandaloneBetaSetup.exe
  4. confirmed 1.64.90 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected, at HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update
  6. verified Omaha updater version 1.3.361.149 is shown C:\Program Files (x86)\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown C:\Program Files (x86)\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for on-demand update - `PASSED`
  1. uninstalled all the Brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserStandaloneSilentBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneSilentBetaSetup.exe
  4. confirmed 1.64.95 installed
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown %LOCALAPPDATA%\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.97
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 4 step 5 step 6 step 7 step 8 step 9 step 10
image image image image image image image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for on-demand update - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. removed local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. downloaded and installed previous public beta version BraveBrowserBetaSetup.exe installer 1.64.95 - https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserBetaSetup.exe
  4. confirmed stub installer for 1.64.97 installed successfully with admin privileges
  5. verified Omaha updater version 1.3.361.149 is shown in the registry as expected
  6. verified Omaha updater version 1.3.361.149 is shown C:\Program Files (x86)\BraveSoftware\Update
  7. go to brave://settings/help and wait for update and click on Relaunch
  8. confirmed brave is updated to the latest public beta version 1.64.102
  9. confirmed Omaha updater version 1.3.361.149 is still shown in the registry as expected
  10. confirmed Omaha updater version 1.3.361.149 is still shown %LOCALAPPDATA%\BraveSoftware\Update
step 5 step 6 step 8 step 9 step 10
image image image image image

Testcase 3 : Background updates via the Windows Task Scheduler - PASSED

Verify correct Omaha updater version installed with `Standalone` installer for Background updates - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an offline (“standalone”) installer for previous non-public version of Brave Beta 1.64.95 (https://github.com/brave/brave-browser/releases/download/v1.64.95/BraveBrowserStandaloneBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.64.95.
  6. Check that the registry value
    BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.149.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 7. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 10. and 11. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.97
step 5 step 6 step 7 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
image image image image image image image image image image step 20 image
Verify correct Omaha updater version installed with `StandaloneSilent` installer for Background updates - `PASSED`
  1. uninstalled all the brave versions (Release, Beta and Nightly) via Brave Manager
  2. Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Download an silent (“StandaloneSilent”) installer for previous non-public version of Brave Beta 1.63.141(https://github.com/brave/brave-browser/releases/download/v1.63.141/BraveBrowserStandaloneSilentBetaSetup.exe).
  4. Disconnect from the internet to prevent accidental automatic updates.
  5. Installed Brave successfully 1.63.141.
  6. Check that the registry value
    BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv is 1.3.361.145.
  7. Write down the registry value BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap - beta
  8. Change the registry value in step 7. to “non-existent” (without quotation marks). This assigns the browser to a non-existent channel, which prevents it from getting updated in the next steps.
  9. Create the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap and set it to beta. This changes the update channel for Omaha itself.
  10. Connect to the internet.
  11. Delete the registry value BraveSoftware\Update\LastChecked if it exists.
  12. Run the “UA” task in the Windows Task Scheduler. This can take 2-3 minutes. Refresh with F5 until the task status has switched back from Running to Ready.
  13. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.151. This means that Omaha was successfully updated.
  14. Check that BraveUpdate.exe in Omaha’s installation directory has a digital signature that expires in August 2024. (Right-click -> Properties -> Digital Signatures -> sha1 / sha256 -> Details-> View Certificate -> Valid from … to.) The most critical thing we want to check is that the updater is not left in a broken state by the update. To do this, we will now simulate another update of the updater.
  15. Change the registry value BraveSoftware\Update\ClientState\{B131C935-9BE6-41DA-9599-1F776BEB8019}\ap to nightly.
  16. Repeat steps 10. and 11. to simulate another background update cycle.
  17. Check the registry value BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}\pv. It should have changed to 1.3.361.153. This means that Omaha was successfully updated again. Now we want to check that on-demand updates of the browser still work. We’ll trust that background updates work because we just performed two of them.
  18. Restore BraveSoftware\Update\ClientState\{103BD053-949B-43A8-9120-2E424887DE11}\ap to its original value (beta)
  19. Open Brave.
  20. Navigate to brave://settings/help. Check that this updates Brave to the latest public version.
  21. Confirmed Brave updated to latest public version 1.64.97
step 5 step 6 step 7 step 8 step 9 step 13 step 14 step 15 step 17 step 18 step 20 step 21
image image image image image image image image image image image image

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 12, 2024
@LaurenWags LaurenWags mentioned this issue Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherrmann mherrmann

Labels
feature/updater installer/omaha Issues for windows omaha installer OS/Desktop OS/Windows QA Pass-Win64 QA Pass-Win86 QA/Yes release-notes/include
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Bump DEP Omaha to 1.3.361.149 brave/brave-core
5 participants
@stephendonner @mherrmann @LaurenWags @brave-builds @MadhaviSeelam